-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Remove some type hell with SchemaTypeLinks #1837
Merged
dhedey
merged 3 commits into
feature/schema-comparisons
from
feature/schema-comparisons-part-1b
Jun 27, 2024
Merged
refactor: Remove some type hell with SchemaTypeLinks #1837
dhedey
merged 3 commits into
feature/schema-comparisons
from
feature/schema-comparisons-part-1b
Jun 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker tags |
Benchmark for 8eca17cClick to view benchmark
|
Merged into the underlying PR at Yulong's request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Minor refactor to improve the type hell when dealing with schemas.
Part A
Builds on top of #1836 (will need merging after)
Notably it:
CustomSchema::CustomTypeKind<L>
for explicitCustomSchema::CustomLocalTypeKind
andCustomSchema::AggregatorLocalTypeKind
which simplifies a lotPart B
Adds a
CustomSchema::DefaultCustomExtension
which we can use for encoding/decoding the schemas, which allows us to remove lots of really ugly/confusing bounds around the specific extension which we use for schema comparison, allowing us to just talk in terms ofCustomSchema
- because the schemas now know how to encode/decode themselves against the default extension.The default extension for
ScryptoCustomSchema
is nowScryptoExtension
(chosen overManifestExtension
for sanity).Update Recommendations
If you get a compile error, change:
CustomSchema::CustomTypeKind<LocalTypeId>
toCustomSchema::CustomLocalTypeKind
CustomSchema::CustomTypeKind<RustTypeId>
toCustomSchema::AggregatorLocalTypeKind