Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] JDBC SET SESSION TRANSACTION ISOLATION LEVEL READ COMMITTED error #629

Closed
BohuTANG opened this issue Apr 30, 2020 · 1 comment
Closed

[bug] JDBC SET SESSION TRANSACTION ISOLATION LEVEL READ COMMITTED error #629

BohuTANG opened this issue Apr 30, 2020 · 1 comment
Assignees
@BohuTANG @zhyass
Labels
P0 High priority type: bug Something isn't working
Milestone
v1.1.1

Comments

@BohuTANG
Copy link
Contributor

BohuTANG commented Apr 30, 2020 •
edited
Loading

Summary

Radon returns error from JDBC(5.1.47)

SET SESSION TRANSACTION ISOLATION LEVEL READ COMMITTED
@BohuTANG BohuTANG added type: bug Something isn't working P0 High priority labels Apr 30, 2020
@BohuTANG BohuTANG added this to the v1.1.1 milestone Apr 30, 2020
@zhyass
Copy link
Contributor

zhyass commented May 11, 2020

ACK

zhyass added a commit to zhyass/radon that referenced this issue May 12, 2020
@zhyass
*: enhance set statement syntax radondb#629
5a5d802 
[summary]
1. reference: https://dev.mysql.com/doc/refman/5.7/en/set-variable.html
```
SET variable = expr [, variable = expr] ...

variable: {
    user_var_name
  | param_name
  | local_var_name
  | {GLOBAL | @@global.} system_var_name
  | [SESSION | @@SESSION. | @@] system_var_name
}
```
2. reference: https://dev.mysql.com/doc/refman/5.7/en/set-transaction.html
```
SET variable = expr [, variable = expr] ...

variable: {
    user_var_name
  | param_name
  | local_var_name
  | {GLOBAL | @@global.} system_var_name
  | [SESSION | @@SESSION. | @@] system_var_name
}
```
[test case]
src/proxy/set_test.go
src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/set_test.go
[patch codecov]
src/proxy/set.go 94.6%
src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast.go 88.0%
zhyass added a commit to zhyass/radon that referenced this issue May 12, 2020
@zhyass
*: enhance set statement syntax radondb#629
812bb2f 
[summary]
1. reference: https://dev.mysql.com/doc/refman/5.7/en/set-variable.html
```
SET variable = expr [, variable = expr] ...

variable: {
    user_var_name
  | param_name
  | local_var_name
  | {GLOBAL | @@global.} system_var_name
  | [SESSION | @@SESSION. | @@] system_var_name
}
```
2. reference: https://dev.mysql.com/doc/refman/5.7/en/set-transaction.html
```
SET [GLOBAL | SESSION] TRANSACTION
    transaction_characteristic [, transaction_characteristic] ...

transaction_characteristic: {
    ISOLATION LEVEL level
  | access_mode
}

level: {
     REPEATABLE READ
   | READ COMMITTED
   | READ UNCOMMITTED
   | SERIALIZABLE
}

access_mode: {
     READ WRITE
   | READ ONLY
}
```
[test case]
src/proxy/set_test.go
src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/set_test.go
[patch codecov]
src/proxy/set.go 94.6%
src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast.go 88.0%
zhyass added a commit to zhyass/radon that referenced this issue May 13, 2020
@zhyass
*: enhance set statement syntax radondb#629
8993581 
[summary]
1. reference: https://dev.mysql.com/doc/refman/5.7/en/set-variable.html
```
SET variable = expr [, variable = expr] ...

variable: {
    user_var_name
  | param_name
  | local_var_name
  | {GLOBAL | @@global.} system_var_name
  | [SESSION | @@SESSION. | @@] system_var_name
}
```
2. reference: https://dev.mysql.com/doc/refman/5.7/en/set-transaction.html
```
SET [GLOBAL | SESSION] TRANSACTION
    transaction_characteristic [, transaction_characteristic] ...

transaction_characteristic: {
    ISOLATION LEVEL level
  | access_mode
}

level: {
     REPEATABLE READ
   | READ COMMITTED
   | READ UNCOMMITTED
   | SERIALIZABLE
}

access_mode: {
     READ WRITE
   | READ ONLY
}
```
[test case]
src/proxy/set_test.go
src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/set_test.go
[patch codecov]
src/proxy/set.go 94.6%
src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast.go 88.0%
BohuTANG added a commit that referenced this issue May 13, 2020
@BohuTANG
Merge pull request #636 from zhyass/feature_set
d646644 
*: enhance set statement syntax #629
@zhyass zhyass closed this as completed May 13, 2020
zhyass added a commit to zhyass/radon that referenced this issue May 13, 2020
@zhyass
intergration: add set statement test cases radondb#629
5d9f61d 
[summary]
add intergration set.test
[test case]
N/A
[patch codecov]
N/A
BohuTANG added a commit that referenced this issue May 14, 2020
@BohuTANG
Merge pull request #637 from zhyass/feature_set
dd4f717 
intergration: add set statement test cases #629
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BohuTANG BohuTANG

@zhyass zhyass

Labels
P0 High priority type: bug Something isn't working
Projects
None yet
Milestone
v1.1.1
Development

No branches or pull requests
2 participants
@BohuTANG @zhyass