Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Giveaway Extractor: fix bug that does not filter giveaways correctly when used in a new tab #1421

Closed
at46 opened this issue Jul 12, 2019 · 0 comments
Labels
Milestone

Comments

@at46
Copy link

at46 commented Jul 12, 2019

Description
When using giveaway extractor with entered filters only the first giveaway I enter with the enter button is filtered. The Second, third and so on are not filtered until I disable and re-enable the filter.

Steps to Reproduce

  1. you need at least giveaway extractor, enter button and giveaway filter for entered (maybe also new tab for giveaway extractor)
  2. configure the filter for giveaway extractor to filter entered games
  3. use giveaway extractor e.g. here https://www.steamgifts.com/discussion/qeDja/
  4. enter two giveaways

Expected Behavior
Automatically filter all entered giveaways not only the first one.

Console Errors
Promise resolved while context is inactive esgst.js:1

Screenshots
ga_extractor_filter

System (please complete the following information):

  • ESGST Version: Extension v8.3.17
  • Browser + Version: Firefox v68
@rafaelgomesxyz rafaelgomesxyz added this to the 8.3.18 milestone Aug 28, 2019
@rafaelgomesxyz rafaelgomesxyz changed the title giveaway extractor filter for entered games not updated on entering Giveaway Extractor: fix bug that does not filter giveaways correctly when used in a new tab Aug 28, 2019
rafaelgomesxyz added a commit that referenced this issue Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants