Made port used for devserver configurable #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for PR. Could you provide a description informing what this PR adds to the project? |
|
Sorry about that. Here's the description |
rafalp
changed the title
|
Could you please rename this env variable to |
|
Sure. |
rafalp
approved these changes
Dec 20, 2018
|
Thank you, I'll merge when travis returns green light 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was developing, I found that misago's ports were hardcoded and conflicted with existing ports
So do these changes, allowing from environment variables PORT_DJANGO define the actual exposed port. If there is no defined PORT_DJANGO, port is the default value of 8000