Django2.2 #1228
Merged
Django2.2 #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstead of Statment. TypeError: argument of type 'Statement' is not iterable
…ly" and a few other small fixes.
This reverts commit 704d1f1.
|
😱 |
rafalp
reviewed
May 15, 2019
rafalp
reviewed
May 15, 2019
rafalp
reviewed
May 15, 2019
rafalp
reviewed
May 15, 2019
| @@ -39,7 +39,7 @@ def test_empty_request(self): | |||
| def test_invalid_data(self): | |||
| """invalid request data errors with code 400""" | |||
| response = self.client.post( | |||
| self.api_link, "false", content_type="application/json" | |||
| self.api_link, {}, content_type="application/json" | |||
There was a problem hiding this comment.
This test was explicitly checking if non-dict data is handled by rest framework.
There was a problem hiding this comment.
venv/misago/lib/python3.6/site-packages/django/forms/widgets.py:258:
return data.get(name)
E AttributeError: 'bool' object has no attribute 'get'
rafalp
reviewed
May 15, 2019
rafalp
reviewed
May 15, 2019
rafalp
reviewed
May 15, 2019
devproject/test_settings.py
Outdated
| @@ -56,3 +56,15 @@ | |||
| } | |||
|
|
|||
| TEST_NAME = "travis_ci_test" | |||
|
|
|||
| AUTH_PASSWORD_VALIDATORS = [ | |||
There was a problem hiding this comment.
Suggested change
| AUTH_PASSWORD_VALIDATORS = [ | |
| # Simplify password validation to ease writing test assertions | |
| AUTH_PASSWORD_VALIDATORS = [ |
There was a problem hiding this comment.
Can you move this setting near the PASSWORD_HASHERS?
rafalp
reviewed
May 15, 2019
rafalp
approved these changes
May 17, 2019
rafalp
added
area: backend
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.