Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move settings from settings.py to database #1241

Merged
merged 28 commits into from
Jun 8, 2019
Merged

Move settings from settings.py to database #1241

merged 28 commits into from
Jun 8, 2019

Conversation

rafalp
Copy link
Owner

@rafalp rafalp commented May 30, 2019 •
edited
Loading

This PR moves some settings from settings.py to database, making them easily changeable by site admins.

Fixes #1134

SETTINGS

  • MISAGO_POST_ATTACHMENTS_LIMIT -> post_attachments_limit
  • MISAGO_DIALY_POST_LIMIT -> daily_post_limit
  • MISAGO_HOURLY_POST_LIMIT -> hourly_post_limit
  • MISAGO_404_IMAGE -> attachment_404_image
  • MISAGO_403_IMAGE -> attachment_403_image
  • MISAGO_ATTACHMENT_ORPHANED_EXPIRE -> unused_attachments_lifetime
  • MISAGO_READTRACKER_CUTOFF -> readtracker_cutoff
  • MISAGO_THREADS_PER_PAGE -> threads_per_page
  • MISAGO_POSTS_PER_PAGE -> posts_per_page
  • MISAGO_POSTS_TAIL -> posts_per_page_orphans
  • MISAGO_EVENTS_PER_PAGE -> events_per_page
  • MISAGO_USE_STOP_FORUM_SPAM -> enable_stop_forum_spam
  • MISAGO_STOP_FORUM_SPAM_MIN_CONFIDENCE -> stop_forum_spam_confidence
  • MISAGO_RANKING_LENGTH -> top_posters_ranking_length
  • MISAGO_RANKING_SIZE -> top_posters_ranking_size
  • MISAGO_USER_DATA_DOWNLOADS_EXPIRE_IN_HOURS -> data_downloads_expiration
  • MISAGO_ENABLE_DOWNLOAD_OWN_DATA -> allow_data_downloads
  • MISAGO_ENABLE_DELETE_OWN_ACCOUNT -> allow_delete_own_account
  • MISAGO_DELETE_NEW_INACTIVE_USERS_OLDER_THAN_DAYS -> new_inactive_accounts_delete
  • MISAGO_IP_STORE_TIME -> ip_storage_time
  • MISAGO_ANONYMOUS_USERNAME -> anonymous_username
  • MISAGO_USERS_PER_PAGE -> users_per_page, users_per_page_orphans

TODO

  • Move settings
  • Update docs
  • Update dev project settings

@rafalp rafalp added area: backend This issue involves Python, Django or dependency (eg. database) area: theme This issue involves HTML and CSS enhancement Improvement to existing feature or dev experience labels May 30, 2019
@rafalp rafalp added this to the 0.20.0 milestone May 30, 2019
@rafalp rafalp self-assigned this May 30, 2019
rafalp added 24 commits June 1, 2019 16:45
@rafalp
Add daily and hourly posting limits settings to admin
5d0def8
@rafalp
Make attachment not found and permission denied images customizable
a05acb7
@rafalp
Move users pagination setting to admin
cd47d20
@rafalp
Add unused attachments lifetime setting to admin
42a2ebf
@rafalp
WIP move readtracker tests to pytest
7964973
@rafalp
Move some readtracker tests to pytest
b00b661
@rafalp
Move readtracker tests to pytest
20b14d1
@rafalp
Commit readtracker conftest and test event handling in threads readtr…
5bac6df 
…acker
@rafalp
Add event tests to categories read tracker
b4cf6e4
@rafalp
Update readtracker tests to test if event permissions are accounted for
10bd4ec
@rafalp
Fix tests
f88b08e
@rafalp
Fix categories utils tests
33cc70d
@rafalp
Replace MISAGO_THREADS_PER_PAGE with dynamic setting
1e9c740
@rafalp
Move dynamic setting overrides to decorators
0b6cbb8
@rafalp
Move posts and events pagination to dynamic settings
498a8cd
@rafalp
Replace _tail with _orphans
77336a7
@rafalp
Make stop forum spam integration configurable in admin
3164388
@rafalp
Move active posters ranking settings to database
3509fb1
@rafalp
Make data downloads configurable in admin panel
61aebc0
@rafalp
Rename stop_forum_spam to enable_stop_forum_spam
b85a5c5
@rafalp
Make own account deletion configurable in admin
a0c6656
@rafalp
Make automatic deletion of inactive user accounts configurable in admin
8a36a9c
@rafalp
Make IP store time configurable from the admin panel
134b9c1
@rafalp
Fix autid trail tests
74b30d9
@rafalp rafalp mentioned this pull request Jun 8, 2019
Closed
@rafalp rafalp merged commit fafa7d8 into master Jun 8, 2019
@rafalp rafalp deleted the move-settings-to-db branch June 8, 2019 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rafalp rafalp

Labels
area: backend This issue involves Python, Django or dependency (eg. database) area: theme This issue involves HTML and CSS enhancement Improvement to existing feature or dev experience
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.

Move Misago settings from settings.py to database
1 participant
@rafalp