Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add icon admin #1245

Merged
merged 10 commits into from
Jun 10, 2019
Merged

Add icon admin #1245

merged 10 commits into from
Jun 10, 2019

Conversation

rafalp
Copy link
Owner

@rafalp rafalp commented Jun 9, 2019 •
edited
Loading

This PR adds admin interface for setting favicon and apple touch icon

Fixes #1186

TODO

  • Add image validators to form
  • Display already set images in admin form
  • Allow deletion of already set image
  • Write tests
  • Replace default branded icons with placeholder icons

@rafalp rafalp added area: frontend This issue involves JavaScript, React.js and Node area: backend This issue involves Python, Django or dependency (eg. database) new feature New feature labels Jun 9, 2019
@rafalp rafalp added this to the 0.20.0 milestone Jun 9, 2019
@rafalp rafalp self-assigned this Jun 9, 2019
@rafalp rafalp mentioned this pull request Jun 10, 2019
Closed
@rafalp rafalp merged commit 3d09d69 into master Jun 10, 2019
@rafalp rafalp deleted the add-icon-admin branch June 10, 2019 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rafalp rafalp

Labels
area: backend This issue involves Python, Django or dependency (eg. database) area: frontend This issue involves JavaScript, React.js and Node new feature New feature
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.

Customize site icon and favicon from admin panel
1 participant
@rafalp