Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal thread views #1796

Merged
merged 16 commits into from
Aug 24, 2024
Merged

Minimal thread views #1796

merged 16 commits into from
Aug 24, 2024

Conversation

rafalp
Copy link
Owner

@rafalp rafalp commented Aug 18, 2024

Adds minimal thread views that can be later completed with missing features in smaller PRs

Part of the #1774 epic

TODO

  • Generic thread view
  • Generic private thread view
  • Minimal thread view
    • Check see permissions
    • Redirect if slug is outdated
    • Check posts permissions
    • Paginated posts list
    • Redirect if page is invalid
  • Minimal private thread view
    • Check see permissions
    • Redirect if slug is outdated
    • Check posts permissions
    • Paginated posts list
    • Redirect if page is invalid
  • Plugin hooks
  • Template plugin outlets
  • Update hooks reference

@rafalp rafalp added area: frontend This issue involves JavaScript, React.js and Node area: backend This issue involves Python, Django or dependency (eg. database) area: theme This issue involves HTML and CSS feature: thread page Thread and private thread pages labels Aug 18, 2024
@rafalp rafalp added this to the Next feature release milestone Aug 18, 2024
@rafalp rafalp self-assigned this Aug 18, 2024
@rafalp
Copy link
Owner Author

rafalp commented Aug 19, 2024

This PR will break tests. Fixing those will take a while because some of them rely on features not yet present in new thread views.

@rafalp
Copy link
Owner Author

rafalp commented Aug 19, 2024

I've deleted bunch of test suites for previous implementation of this view. Only tests failing now are from redirects views. I'll merge this when I finish the todo, then implement new redirect views using new permissions and plugins. That should fix our tests suite and leave me to work on next stuff.

@rafalp rafalp merged commit 336f5f2 into main Aug 24, 2024
1 check failed
@rafalp rafalp deleted the basic-thread-views branch September 5, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: backend This issue involves Python, Django or dependency (eg. database) area: frontend This issue involves JavaScript, React.js and Node area: theme This issue involves HTML and CSS feature: thread page Thread and private thread pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant