-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix cat for vectors with AnonDim #502
Conversation
Codecov Report
@@ Coverage Diff @@
## main #502 +/- ##
==========================================
- Coverage 89.38% 89.01% -0.38%
==========================================
Files 39 39
Lines 2846 2868 +22
==========================================
+ Hits 2544 2553 +9
- Misses 302 315 +13
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I'll take a look at this later today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any obvious problems, but I did notice that a _print_matrix
method in show.jl
is no longer being covered by the test suite (hence the decrease in coverage).
The I'll ckean up the coverage thanks for catching that. |
hcat
andvcat
were not tested with DimVector and were not actually working. This PR fixes that. It also standardises the output ofcat
on missing dimensions to useAnonDim
so we always return aDimArray
.We also now rigorously check that the shared dimensions actually match all values as well as dimension type, and that span types are not mixed or broken (closes #433)
@sethaxen you may want a look at this, I think this was partly your code
Note: also fixed problems in docs in primatives as I used the keywords here