Merge pull request #830 from rage/relay-data-to-plagiarism-backend

Relay data to plagiarism backend
rage · Oct 3, 2021 · 9837e19 · 9837e19
2 parents d0c3dd1 + 42bf633
commit 9837e19
Show file tree

Hide file tree

Showing 9 changed files with 175 additions and 5 deletions.
diff --git a/kubernetes/backendv2-deployment.yaml b/kubernetes/backendv2-deployment.yaml
@@ -96,6 +96,16 @@ spec:
               secretKeyRef:
                 name: backend-database-secret
                 key: SENTRY_DSN
+          - name: CSD_URL
+            valueFrom:
+              secretKeyRef:
+                name: backend-database-secret
+                key: CSD_URL
+          - name: JWT_SECRET
+            valueFrom:
+              secretKeyRef:
+                name: backend-database-secret
+                key: JWT_SECRET
       initContainers:
         - name: quizzes-backendv2-run-migrations
           image: ${BACKENDV2_IMAGE}

diff --git a/packages/backendv2/database/migrations/20210930184939_add_column_check_plagiarism_to_quiz.ts b/packages/backendv2/database/migrations/20210930184939_add_column_check_plagiarism_to_quiz.ts
@@ -0,0 +1,11 @@
+import * as Knex from "knex"
+
+export async function up(knex: Knex): Promise<void> {
+  await knex.raw(
+    `alter table quiz add column check_plagiarism boolean default false;`,
+  )
+}
+
+export async function down(knex: Knex): Promise<void> {
+  await knex.raw(`alter table quiz drop column check_plagiarism;`)
+}
diff --git a/packages/backendv2/package-lock.json b/packages/backendv2/package-lock.json
diff --git a/packages/backendv2/package.json b/packages/backendv2/package.json
@@ -11,7 +11,7 @@
     "dev": "concurrently npm:ts-watch npm:watch",
     "test": "cross-env NODE_ENV=test && jest --runInBand",
     "test-open-conn": "cross-env NODE_ENV=test && jest --runInBand --detectOpenHandles ",
-    "reset-test-db": "cross-env NODE_ENV=test && (dropdb quizzes_test || true) && createdb quizzes_test && knex migrate:latest",
+    "reset-test-db": "cross-env NODE_ENV=test && (dropdb quizzes_test || true) && createdb quizzes_test && cross-env NODE_ENV=test && knex migrate:latest",
     "migrate": "knex migrate:latest",
     "seed": "knex seed:run --specific a.ts",
     "update-expired-courses": "node ./dist/bin/update-expired-courses.js",
@@ -46,6 +46,7 @@
     "@types/csv-parse": "^1.2.2",
     "@types/csv-stringify": "^3.1.0",
     "@types/jsonstream": "^0.8.30",
+    "@types/jsonwebtoken": "^8.5.4",
     "@types/lodash": "^4.14.161",
     "JSONStream": "^1.3.5",
     "axios": "^0.21.1",
@@ -54,6 +55,7 @@
     "dotenv": "^8.2.0",
     "ioredis": "^4.19.4",
     "jsonstream": "^1.0.3",
+    "jsonwebtoken": "^8.5.1",
     "knex": "^0.21.1",
     "koa": "^2.12.0",
     "koa-bodyparser": "^4.3.0",

diff --git a/packages/backendv2/src/models/language.ts b/packages/backendv2/src/models/language.ts
@@ -1,6 +1,8 @@
 import BaseModel from "./base_model"
 
 class Language extends BaseModel {
+  name!: string
+
   static get tableName() {
     return "language"
   }

diff --git a/packages/backendv2/src/models/quiz.ts b/packages/backendv2/src/models/quiz.ts
@@ -35,6 +35,7 @@ export class Quiz extends BaseModel {
   title!: string
   body!: string
   submitMessage!: string
+  checkPlagiarism!: boolean
 
   static get tableName() {
     return "quiz"

diff --git a/packages/backendv2/src/models/quiz_answer.ts b/packages/backendv2/src/models/quiz_answer.ts
@@ -21,6 +21,8 @@ import softDelete from "objection-soft-delete"
 import { mixin } from "objection"
 import QuizAnswerStatusModification from "./quiz_answer_status_modification"
 import { TStatusModificationOperation } from "./../types/index"
+import { relayNewAnswer } from "../services/plagiarism"
+import Language from "./language"
 
 type QuizAnswerStatus =
   | "draft"
@@ -581,6 +583,9 @@ class QuizAnswer extends mixin(BaseModel, [
       }
       await trx.commit()
       quiz.course = course
+      if (quiz.checkPlagiarism) {
+        await this.relayPlagiarismData(savedQuizAnswer, quiz)
+      }
       return {
         quiz,
         quizAnswer: savedQuizAnswer,
@@ -592,6 +597,26 @@ class QuizAnswer extends mixin(BaseModel, [
     }
   }
 
+  private static async relayPlagiarismData(quizAnswer: QuizAnswer, quiz: Quiz) {
+    const language = await Language.query().findById(quiz.course.languageId)
+    for (const quizItem of quiz.items) {
+      if (quizItem.type === "essay") {
+        const itemAnswer = quizAnswer.itemAnswers.find(
+          itemAnswer => itemAnswer.quizItemId === quizItem.id,
+        )
+        if (itemAnswer) {
+          relayNewAnswer({
+            quizId: quiz.id,
+            quizAnswerId: quizAnswer.id,
+            quizItemAnswerId: itemAnswer.id,
+            language: language.name.split(" ")[0].toLowerCase(),
+            data: itemAnswer.textData,
+          })
+        }
+      }
+    }
+  }
+
   public static async update(
     quizAnswer: QuizAnswer,
     userQuizState: UserQuizState,

diff --git a/packages/backendv2/src/services/plagiarism.ts b/packages/backendv2/src/services/plagiarism.ts
@@ -0,0 +1,27 @@
+import axios from "axios"
+import jwt from "jsonwebtoken"
+import { GlobalLogger } from "../middleware/logger"
+
+const CancelToken = axios.CancelToken
+const source = CancelToken.source()
+
+export const relayNewAnswer = async (data: any) => {
+  try {
+    const csd_url = process.env.CSD_URL || "http://localhost/5150"
+    await axios.post(csd_url + "/new", data, {
+      headers: {
+        authorization: jwt.sign(
+          { source: "quizzes" },
+          process.env.JWT_SECRET || "",
+        ),
+      },
+      cancelToken: source.token,
+    })
+    setTimeout(() => {
+      GlobalLogger.warn("plagiarism detection: request timed out")
+      source.cancel()
+    }, 10000)
+  } catch (error) {
+    GlobalLogger.error("plagiarism detection: backend responded with error")
+  }
+}
diff --git a/packages/backendv2/tests/data.ts b/packages/backendv2/tests/data.ts
@@ -15,6 +15,7 @@ export const input = {
     awardPointsEvenIfWrong: false,
     grantPointsPolicy: "grant_whenever_possible",
     autoReject: true,
+    checkPlagiarism: false,
     title: "quiz",
     body: "body",
     submitMessage: "nice one!",
@@ -86,6 +87,7 @@ export const input = {
     awardPointsEvenIfWrong: false,
     grantPointsPolicy: "grant_whenever_possible",
     autoReject: true,
+    checkPlagiarism: false,
     title: "quiz",
     body: "body",
     submitMessage: "nice one!",
@@ -238,6 +240,8 @@ interface QuizValidator {
   awardPointsEvenIfWrong: false
   grantPointsPolicy: "grant_whenever_possible"
   autoReject: true
+
+  checkPlagiarism: false
   title: "quiz"
   body: "body"
   submitMessage: "nice one!"
@@ -261,6 +265,7 @@ export const validation = {
     awardPointsEvenIfWrong: false,
     grantPointsPolicy: "grant_whenever_possible",
     autoReject: true,
+    checkPlagiarism: false,
     title: "quiz",
     body: "body",
     submitMessage: "nice one!",
@@ -375,6 +380,7 @@ export const validation = {
     awardPointsEvenIfWrong: false,
     grantPointsPolicy: "grant_whenever_possible",
     autoReject: true,
+    checkPlagiarism: false,
     title: "quiz",
     body: "body",
     submitMessage: "nice one!",
@@ -475,6 +481,7 @@ export const validation = {
     awardPointsEvenIfWrong: false,
     grantPointsPolicy: "grant_whenever_possible",
     autoReject: true,
+    checkPlagiarism: false,
     title: "quiz 1",
     body: "body",
     submitMessage: "nice one!",
@@ -589,6 +596,7 @@ export const validation = {
     awardPointsEvenIfWrong: false,
     grantPointsPolicy: "grant_whenever_possible",
     autoReject: true,
+    checkPlagiarism: false,
     title: "quiz 2",
     body: "body",
     submitMessage: "nice one!",
@@ -663,6 +671,7 @@ export const validation = {
     awardPointsEvenIfWrong: false,
     grantPointsPolicy: "grant_whenever_possible",
     autoReject: true,
+    checkPlagiarism: false,
     title: "quiz",
     body: "body",
     submitMessage: "nice one!",
@@ -737,6 +746,7 @@ export const validation = {
     awardPointsEvenIfWrong: false,
     grantPointsPolicy: "grant_whenever_possible",
     autoReject: true,
+    checkPlagiarism: false,
     title: "quiz",
     body: "body",
     submitMessage: "nice one!",
@@ -990,6 +1000,7 @@ export const validation = {
     quiz: {
       autoConfirm: true,
       autoReject: true,
+      checkPlagiarism: false,
       awardPointsEvenIfWrong: false,
       courseId: "46d7ceca-e1ed-508b-91b5-3cc8385fa44b",
       createdAt: expect.stringMatching(dateTime),
@@ -1271,6 +1282,7 @@ export const validation = {
       excludedFromScore: false,
       autoConfirm: true,
       autoReject: true,
+      checkPlagiarism: false,
       triesLimited: true,
       tries: 1,
       grantPointsPolicy: "grant_whenever_possible",
@@ -1460,6 +1472,7 @@ export const validation = {
     excludedFromScore: false,
     autoConfirm: true,
     autoReject: true,
+    checkPlagiarism: false,
     triesLimited: true,
     tries: 1,
     grantPointsPolicy: "grant_whenever_possible",