FIX: Condition that check if channel need to be swapped #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@raghakot can you consider this pull request. Unitests are failing due to previous bugs. |
raghakot
reviewed
Jul 12, 2018
vis/optimizer.py
Outdated
| @@ -93,7 +93,8 @@ def _get_seed_input(self, seed_input): | |||
| seed_input = np.expand_dims(seed_input, 0) | |||
|
|
|||
| # Only possible if channel idx is out of place. | |||
| if seed_input.shape != desired_shape: | |||
| if seed_input.shape[3] != desired_shape[3] and \ | |||
There was a problem hiding this comment.
better to use shape[-1] since the input could be n-dim tensor. looks good otherwise.
There was a problem hiding this comment.
fixed. @raghakot do you have an idea how to fix the unit-test issues.
raghakot
reviewed
Jul 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
seed_inputcan have a shape with unknown values, e.g. [1, None, None, 3] in the channel_last case. That causes the fixed condition isFalseand representation changes from channel_last to channel_first and vice-versa.Fix
Condition fixed to check only whether the channel is channel_last or channel_first. One of condition always keeps when the same representation.