Update from original #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I see no reason why this should be done, the fatal error is used in following cases: * Very early when there is no session (eg. missing extension) * Invalid value for parameters * Invalid invocation like too big request In neither case session removal will do any good. Signed-off-by: Michal Čihař <michal@cihar.com>
Fixed stored procedure execution. Fixes #12813 Signed-off-by: Michal Čihař <michal@cihar.com>
We can not rely on whole stack being ready. Fixes #12810 Signed-off-by: Michal Čihař <michal@cihar.com>
Currently translated at 100.0% (3222 of 3222 strings) [CI skip]
Currently translated at 100.0% (3239 of 3239 strings) [CI skip]
Currently translated at 100.0% (3222 of 3222 strings) [CI skip]
Currently translated at 100.0% (3239 of 3239 strings) [CI skip]
Currently translated at 100.0% (3222 of 3222 strings) [CI skip]
… too Fix #12814 Ref : http://dev.mysql.com/doc/refman/5.7/en/fractional-seconds.html Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
Signed-off-by: Michal Čihař <michal@cihar.com>
Signed-off-by: Michal Čihař <michal@cihar.com>
This avoids additional call in the shutdown handler. Signed-off-by: Michal Čihař <michal@cihar.com>
Signed-off-by: Michal Čihař <michal@cihar.com>
Fixes #12786 Signed-off-by: Michal Čihař <michal@cihar.com>
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
Currently translated at 100.0% (3222 of 3222 strings) [CI skip]
Currently translated at 99.8% (3234 of 3239 strings) [CI skip]
Issue #12348 Signed-off-by: Michal Čihař <michal@cihar.com>
Fixes #12802 Signed-off-by: Michal Čihař <michal@cihar.com>
Do not delete session on fatal error
Fixes #12828 Signed-off-by: Michal Čihař <michal@cihar.com>
* the user set collation is now honored * default value has been changed to utf8mb4 * it is downgraded to utf8 if server does not support it Fixes #12826 Signed-off-by: Michal Čihař <michal@cihar.com>
Signed-off-by: Michal Čihař <michal@cihar.com>
The null is there implicitely anyway. Fixes #12829 Signed-off-by: Michal Čihař <michal@cihar.com>
Issue #12804 Signed-off-by: Michal Čihař <michal@cihar.com>
…base. Signed-off-by: Yunus Çağrı <ycagriyurdakul@gmail.com>
…base. Signed-off-by: Yunus Çağrı <ycagriyurdakul@gmail.com>
Issue #12293 Signed-off-by: Michal Čihař <michal@cihar.com>
Without calling openssl_error_string() we pollute openssl global state and some other library might report this as failure (eg. mysqlnd driver when connecting to SSL enabled server). Fixes #12293 Signed-off-by: Michal Čihař <michal@cihar.com>
Issue #12293 Signed-off-by: Michal Čihař <michal@cihar.com>
This ensures we generate compatible data in both cases. Issue #12293 Signed-off-by: Michal Čihař <michal@cihar.com>
* Added mocking of response object * Rectified mistake of calling method once * implemented mock properly * replaced header with response header Issue #12079 Signed-off-by: Osaid osaid.nasir@gmail.com
Signed-off-by: Yunus Çağrı <ycagriyurdakul@gmail.com>
Signed-off-by: Yunus Çağrı <ycagriyurdakul@gmail.com>
Signed-off-by: Michal Čihař <michal@cihar.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting pull request, please check that every commit: