rai version -p . crashes
#25
Comments
|
I think this is due to a infinite recursion in the Lines 90 to 99 in f2885fc
var VersionCmd = cmd.VersionCmd
func init() {
// The version information command
// Store Run function somewhere else so we can explicitly run it later
var orig_versioncmd_run = VersionCmd.Run
VersionCmd.Run = func(c *cobra.Command, args []string) {
orig_versioncmd_run(c, args)
if ece408ProjectMode {
fmt.Println("ECE408ProjectMode: ", ece408ProjectMode)
}
} |
|
can you make a pull request |
I just made a pull request #27 for it. |
|
I'm not sure what version of the binary is currently linked on the site, but it could be the same problem as #28 |
|
Carl,
You can get the stable amd64 version of rai from https://drive.google.com/open?id=1Pp84x3So9OEHUwRHQVZcRP441wRsO-UV.
I will cross compile for Mac and post as well.
Andy
From: Carl Pearson <notifications@github.com>
Sent: Tuesday, June 25, 2019 4:41 AM
To: rai-project/rai <rai@noreply.github.com>
Cc: Schuh, Andrew <aschuh@illinois.edu>; Assign <assign@noreply.github.com>
Subject: Re: [rai-project/rai] `rai version -p .` crashes (#25)
I'm not sure what version of the binary is currently linked on the site, but it could be the same problem:
#28<#28>
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub<#25?email_source=notifications&email_token=ACP22URNEEXZSR6CCBWYQWLP4HR4PA5CNFSM4GQHI2O2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYPVFFI#issuecomment-505369237>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ACP22USER3WQBNZOAAMBBADP4HR4PANCNFSM4GQHI2OQ>.
|
|
First amd64 binary was not compiled with secret. That has been fixed. In addition, new Darwin binary is available. If they work, share the link below with the class.
Other architectures needed?
Andy
From: Schuh, Andrew
Sent: Tuesday, June 25, 2019 9:09 AM
To: rai-project/rai <reply@reply.github.com>; rai-project/rai <rai@noreply.github.com>
Cc: Assign <assign@noreply.github.com>
Subject: RE: [rai-project/rai] `rai version -p .` crashes (#25)
Carl,
You can get the stable amd64 version of rai from https://drive.google.com/open?id=1Pp84x3So9OEHUwRHQVZcRP441wRsO-UV.
I will cross compile for Mac and post as well.
Andy
From: Carl Pearson <notifications@github.com<mailto:notifications@github.com>>
Sent: Tuesday, June 25, 2019 4:41 AM
To: rai-project/rai <rai@noreply.github.com<mailto:rai@noreply.github.com>>
Cc: Schuh, Andrew <aschuh@illinois.edu<mailto:aschuh@illinois.edu>>; Assign <assign@noreply.github.com<mailto:assign@noreply.github.com>>
Subject: Re: [rai-project/rai] `rai version -p .` crashes (#25)
I'm not sure what version of the binary is currently linked on the site, but it could be the same problem:
#28<#28>
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub<#25?email_source=notifications&email_token=ACP22URNEEXZSR6CCBWYQWLP4HR4PA5CNFSM4GQHI2O2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYPVFFI#issuecomment-505369237>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ACP22USER3WQBNZOAAMBBADP4HR4PANCNFSM4GQHI2OQ>.
|
I merged this |
|
Closing since I think this is resolved |
(Thanks for reporting an issue! Please make sure you click the link above to read contributor guidelines, then fill out the details below)
What are the minimum necessary steps to reproduce this issue?
Run
rai version -p .What happens?
crash
What were you expecting to happen?
Some message about the version
Please paste any error or log messages here
Any other details
…
The text was updated successfully, but these errors were encountered: