Update dev deps and add new mypy check

requirements-dev.txt

@@ -7,15 +7,15 @@ wheel>=0.30.0
 watchdog>=0.8.3
 twine
 
-flake8==3.6.0
+flake8==3.7.8
 flake8-bugbear==19.3.0
-flake8-tuple==0.2.14
-isort==4.3.18
-mypy==0.701
+flake8-tuple==0.4.0
+isort==4.3.21
+mypy==0.720
 black==19.3b0
 pylint==2.3.1
 
-pytest==4.4.1
+pytest==5.0.1
 pytest-runner
 pytest-cov
 pytest-structlog==0.1
@@ -26,7 +26,6 @@ ipython==4.2.1
 pdbpp
 
 eth-tester[py-evm]==0.1.0b33
-attrs==18.2.0  # needed for travis
 
 # Release
 bump2version==0.5.10

setup.cfg

@@ -29,6 +29,7 @@ check_untyped_defs = True
 disallow_untyped_defs = True
 warn_unused_configs = True
 warn_unused_ignores = True
+warn_unreachable = True
 
 [mypy-tests.*]
 disallow_untyped_defs = False

src/monitoring_service/handlers.py

@@ -490,8 +490,7 @@ def action_claim_reward_triggered_event_handler(event: Event, context: Context)
 
     # check that the latest update was ours and that we didn't send a transaction yet
     can_claim = (
-        channel is not None
-        and channel.claim_tx_hash is None
+        channel.claim_tx_hash is None
         and channel.update_status is not None
         and channel.update_status.update_sender_address == context.ms_state.address
     )

src/raiden_libs/cli.py

@@ -49,7 +49,9 @@ def _open_keystore(keystore_file: str, password: str) -> str:
             sys.exit(1)
 
 
-def validate_address(_ctx: click.Context, _param: click.Parameter, value: str) -> Optional[str]:
+def validate_address(
+    _ctx: click.Context, _param: click.Parameter, value: Optional[str]
+) -> Optional[str]:
     if value is None:
         # None as default value allowed
         return None