Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for loop initial declarations C99 error #496

Merged
merged 2 commits into from
May 13, 2021
Merged

Fix for loop initial declarations C99 error #496

merged 2 commits into from
May 13, 2021

Conversation

bvogelzang
Copy link
Contributor

fixes #495

@bvogelzang bvogelzang requested a review from aharpervc May 11, 2021 21:28
aharpervc
aharpervc approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@aharpervc aharpervc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me (I guess, not a C expert). Can you also confirm this works with AL1? Should we cut another prerelease and have @januszm verify?

ext/tiny_tds/result.c Outdated Show resolved Hide resolved
@bvogelzang bvogelzang force-pushed the fix-for-loop-initial-declarations branch from abb4aba to ab6db41 Compare May 13, 2021 15:38
@bvogelzang bvogelzang merged commit c1c9864 into rails-sqlserver:master May 13, 2021
@bvogelzang bvogelzang deleted the fix-for-loop-initial-declarations branch May 13, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aharpervc aharpervc aharpervc approved these changes

@januszm januszm januszm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2.1.4 Compilation error on Amazon Linux 1 loop initial declarations are only allowed in C99 mode
3 participants
@bvogelzang @aharpervc @januszm