PostgreSQL bugfix for invalid SQL in subqueries #243
Conversation
In commit 68a9554 the last_column feature of ToSql was removed. The visit_Arel_Nodes_Matches and visit_Arel_Nodes_DoesNotMatch methods are overwritten in the PostgreSQL class, but were not updated appropriately. This commit fixes the issue accordingly. This bug affects at least all update_all statements in Rails 4.0.2 that have subqueries with ILIKE statements on PostgreSQL. The bug is present in Arel 4.0.1 and later, so it probably affects most Rails 4.0.2 projects. It would be highly appreciated if Arel 4 could get a point release as well. Thanks for your continued work.
|
@vanderhoorn thank you so much for the contribution. Could you create a test case for this failure? With this we can make sure it will not break again in the future. |
|
Well, currently there aren't any tests for the The code in https://gist.github.com/vanderhoorn/8824862 (written by my colleague @StefanH) reproduces the issue. You need a PostgreSQL database named |
|
@vanderhoorn Yeah, that's how we accidentally introduced the bug in the first place. Definitely would help to have a test added. |
…hen using matches() or does_not_match().
|
Done, added tests. As a side-note, @ernie, you may want to blame the original author for not adding tests in the first place ;) |
|
Hey, the tests passed for me! :P |
|
If someone could make a point release for the 4.x branch, that would be really amazing. We maintain the ancestry gem (https://github.com/stefankroes/ancestry). The master branch has some queries changed to use Arel instead of self-written SQL. We cannot release a new version of ancestry, without this bugfix, as it would break many Rails 4.0.2 applications that use ancestry. |
|
Or should I do a commit to the 4-0-stable branch as well? |
PostgreSQL bugfix for invalid SQL in subqueries
PostgreSQL bugfix for invalid SQL in subqueries
|
4.0.2 released |
|
Super! Thanks! |
In commit 68a9554 the last_column feature of ToSql was removed. The visit_Arel_Nodes_Matches and visit_Arel_Nodes_DoesNotMatch methods are overwritten in the PostgreSQL class, but were not updated appropriately. This commit fixes the issue accordingly.
This bug affects at least all update_all statements in Rails 4.0.2 that have subqueries with ILIKE statements on PostgreSQL. The bug is present in Arel 4.0.1 and later, so it probably affects most Rails 4.0.2 projects.
It would be highly appreciated if Arel 4 could get a point release as well. Thanks for your continued work.