Add options to URI::GID to store simple metadata as query parameters. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| h[URI.unescape(k)] = URI.unescape(v) | ||
| end.with_indifferent_access | ||
| end | ||
|
|
There was a problem hiding this comment.
Can rely on decode_www_form for this:
Hash[URI.decode_www_form(@query)].with_indifferent_accessThere was a problem hiding this comment.
Ahh! I've also replaced the #to_query call with URI.encode_www_form(parts[:params]), so it's easier to spot encoding and decoding 😁
kaspth
force-pushed
the
gid-query-params
branch
from
a3f3c0c
to
356f6d4
Compare
|
@jeremy All your concern are addressed by me. |
kaspth
force-pushed
the
gid-query-params
branch
from
356f6d4
to
4c933fb
Compare
kaspth
added a commit
that referenced
this pull request
Oct 8, 2014
Add options to URI::GID to store simple metadata as query parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39.
Ready for review 😁