Patch to make jbuilder work with Ruby 1.8.7 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Enumerable method one? behaves in a similar manner to the any? method such that it checks if the enum has one element that is truthy. This obviously causes problems when trying to set false/nil values as args.one? will return false. Although many? does behave differently to one? and any? in that it depends on the actual number of elements in the enum its use of a block argument causes a performance impact on Ruby 1.8.7.
|
thanks dude works well |
Ruby 1.8 lacks block local variables so a couple of the tests fail because they use the same variable name inside the block. Also a couple of tests need to be eval'd since the implicit call syntax of Ruby 1.9 is seen as a syntax error by Ruby 1.8.
|
Why U not merge this, DHH? |
|
What's with the one?/many? purge? How does that relate to 1.8.7? one? is available in the std lib and active support added many? Can you remove those? Then I can merge. Also, if you can remove the spacing noise from the beginning of the patch. |
|
Did you look at the commit message? There's an argument that the behaviour of |
|
Patrick liked this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know 1.9.3 is where all the hot action is at but spare a thought for us poor souls who have to deploy to REE for the next few months until I can find time to update our servers.