Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #67 & #69 (IE8 perfomance issues). #79

Closed
wants to merge 1 commit into from
Closed

Fixes #67 & #69 (IE8 perfomance issues). #79

wants to merge 1 commit into from

Conversation

gzigzigzeo
Copy link

No description provided.

@JangoSteve
Copy link
Member

Can you please explain this change? Internally in jQuery, .delegate() is just a one-line piece of code that calls .on(). I.e. what you changed doesn't actually do anything, unless they changed that in jQuery 1.8, in which case, I'd like to know what the change is to cause this patch to make a difference.

@gzigzigzeo
Copy link
Author

I can not logically explain it, but this change worked for me in real project. My idea was that IE8 delegate() is internally reserved method or something like this. I know that it's the black magic, so the only meaningful use of this patch is to replace deprecated calls to delegate() with calls to on().

@JangoSteve
Copy link
Member

delegate() is not deprecated and I prefer it to on(). I'd rather know why something is broken/works before changing something that shouldn't make a difference.

@indirect indirect closed this Nov 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants