-
Notifications
You must be signed in to change notification settings - Fork 21.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #10152 from Noemj/statement_cache
Statement cache Conflicts: activerecord/CHANGELOG.md
- Loading branch information
Showing
4 changed files
with
108 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
module ActiveRecord | ||
|
||
# Statement cache is used to cache a single statement in order to avoid creating the AST again. | ||
# Initializing the cache is done by passing the statement in the initialization block: | ||
# | ||
# cache = ActiveRecord::StatementCache.new do | ||
# Book.where(:name => "my book").limit(100) | ||
# end | ||
# | ||
# The cached statement is executed by using the +execute+ method: | ||
# | ||
# cache.execute | ||
# | ||
# The relation returned by yield is cached, and for each +execute+ call the cached relation gets duped. | ||
# Database is queried when +to_a+ is called on the relation. | ||
class StatementCache | ||
def initialize | ||
@relation = yield | ||
raise ArgumentError.new("Statement cannot be nil") if @relation.nil? | ||
end | ||
|
||
def execute | ||
@relation.dup.to_a | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
require 'cases/helper' | ||
require 'models/book' | ||
require 'models/liquid' | ||
require 'models/molecule' | ||
require 'models/electron' | ||
|
||
module ActiveRecord | ||
class StatementCacheTest < ActiveRecord::TestCase | ||
def setup | ||
@connection = ActiveRecord::Base.connection | ||
end | ||
|
||
def test_statement_cache_with_simple_statement | ||
cache = ActiveRecord::StatementCache.new do | ||
Book.where(name: "my book").where("author_id > 3") | ||
end | ||
|
||
Book.create(name: "my book", author_id: 4) | ||
|
||
books = cache.execute | ||
assert_equal "my book", books[0].name | ||
end | ||
|
||
def test_statement_cache_with_nil_statement_raises_error | ||
assert_raise(ArgumentError) do | ||
cache = ActiveRecord::StatementCache.new do | ||
nil | ||
end | ||
end | ||
end | ||
|
||
def test_statement_cache_with_complex_statement | ||
cache = ActiveRecord::StatementCache.new do | ||
Liquid.joins(:molecules => :electrons).where('molecules.name' => 'dioxane', 'electrons.name' => 'lepton') | ||
end | ||
|
||
salty = Liquid.create(name: 'salty') | ||
molecule = salty.molecules.create(name: 'dioxane') | ||
electron = molecule.electrons.create(name: 'lepton') | ||
|
||
liquids = cache.execute | ||
assert_equal "salty", liquids[0].name | ||
end | ||
|
||
def test_statement_cache_values_differ | ||
cache = ActiveRecord::StatementCache.new do | ||
Book.where(name: "my book") | ||
end | ||
|
||
for i in 0..2 do | ||
Book.create(name: "my book") | ||
end | ||
|
||
first_books = cache.execute | ||
|
||
for i in 0..2 do | ||
Book.create(name: "my book") | ||
end | ||
|
||
additional_books = cache.execute | ||
assert first_books != additional_books | ||
end | ||
end | ||
end |