Skip to content

Commit

Permalink
Fix random CI failure due to non-deterministic sorting order
Browse files Browse the repository at this point in the history
  • Loading branch information
kamipo committed Jan 20, 2020
1 parent a070260 commit 11a7e3f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions activerecord/test/cases/calculations_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -778,7 +778,7 @@ def test_pluck_with_includes_offset
end

def test_pluck_with_join
assert_equal [[2, 2], [4, 4]], Reply.includes(:topic).pluck(:id, :"topics.id")
assert_equal [[2, 2], [4, 4]], Reply.includes(:topic).order(:id).pluck(:id, :"topics.id")
end

def test_group_by_with_order_by_virtual_count_attribute
Expand Down Expand Up @@ -860,7 +860,7 @@ def test_pluck_replaces_select_clause

def test_pluck_columns_with_same_name
expected = [["The First Topic", "The Second Topic of the day"], ["The Third Topic of the day", "The Fourth Topic of the day"]]
actual = Topic.joins(:replies)
actual = Topic.joins(:replies).order(:id)
.pluck("topics.title", "replies_topics.title")
assert_equal expected, actual
end
Expand Down

0 comments on commit 11a7e3f

Please sign in to comment.