Skip to content

Commit

Permalink
Tighten up AS.gemspec.
Browse files Browse the repository at this point in the history 
Apparently 0.6.2 has a call to force_encoding, which is not around
in 1.8.7.
  • Loading branch information
@steveklabnik
steveklabnik committed Feb 27, 2013
1 parent 1a88523 commit 197b9f4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion activesupport/activesupport.gemspec
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ Gem::Specification.new do |s|

s.rdoc_options.concat ['--encoding', 'UTF-8']

s.add_dependency('i18n', '~> 0.6')
s.add_dependency('i18n', '= 0.6.1')
s.add_dependency('multi_json', '~> 1.0')
end

6 comments on commit 197b9f4

@carlosantoniodasilva
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💩, their master should be already handling it, but we may need another release fixing the problem.

@steveklabnik
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/me nods

@sferik
Copy link
Contributor

@sferik sferik commented on 197b9f4 Mar 19, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like i18n 0.6.4 was released on the same day as this patch, which fixed the problem on 1.8.7.

The same day, 641a27d was applied to the 3-2-stable branch. How come this change didn’t make it into the 3.2.13 release?

@steveklabnik
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come this change didn’t make it into the 3.2.13 release?

The release branch has it in it: https://github.com/rails/rails/commits/3-2-13

@dlibanori
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎

I coded a project using Rails 3.2.11 with I18n 0.6.4, now I can't upgrade to Rails 3.2.13 because it is forcing I18n 0.6.1 wich expects an array of translations, but I18n 0.6.4 save just a string. All my project has just the first char at translated strings.

@rafaelfranca
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dlibanori use 3-2-stable

Please sign in to comment.