Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Remove ActionController::TestCase#rescue_action_in_public!

This method has no effect since exception handling was
moved to middlewares and ActionController tests do not
use any middlewares.
  • Loading branch information...
commit 5b94e73d1a604c59ecd1ebb9441d60ea864fa1b5 1 parent e884f4b
@drogus drogus authored
View
5 actionpack/lib/action_controller/test_case.rb
@@ -505,11 +505,6 @@ def setup_controller_request_and_response
end
end
- # Cause the action to be rescued according to the regular rules for rescue_action when the visitor is not local
- def rescue_action_in_public!
- @request.remote_addr = '208.77.188.166' # example.com
- end
-
included do
include ActionController::TemplateAssertions
include ActionDispatch::Assertions
View
5 actionpack/test/controller/base_test.rb
@@ -130,8 +130,6 @@ def use_controller(controller_class)
@request = ActionController::TestRequest.new
@response = ActionController::TestResponse.new
@request.host = "www.nextangle.com"
-
- rescue_action_in_public!
end
def test_process_should_be_precise
@@ -155,7 +153,6 @@ class UrlOptionsTest < ActionController::TestCase
def setup
super
@request.host = 'www.example.com'
- rescue_action_in_public!
end
def test_url_for_query_params_included
@@ -206,7 +203,6 @@ class DefaultUrlOptionsTest < ActionController::TestCase
def setup
super
@request.host = 'www.example.com'
- rescue_action_in_public!
end
def test_default_url_options_override
@@ -257,7 +253,6 @@ class EmptyUrlOptionsTest < ActionController::TestCase
def setup
super
@request.host = 'www.example.com'
- rescue_action_in_public!
end
def test_ensure_url_for_works_as_expected_when_called_with_no_options_if_default_url_options_is_not_set
Please sign in to comment.
Something went wrong with that request. Please try again.