Remove useless select_values += select_values

`select_values` is a local variable defined at previous line. `select_values += select_values` is totally useless.
rails · Feb 26, 2017 · 97d46c1 · 97d46c1
1 parent 83f7f4f
commit 97d46c1
Showing 1 changed file with 0 additions and 1 deletion.
diff --git a/activerecord/lib/active_record/relation/calculations.rb b/activerecord/lib/active_record/relation/calculations.rb
@@ -282,7 +282,6 @@ def execute_grouped_calculation(operation, column_name, distinct) #:nodoc:
             operation,
             distinct).as(aggregate_alias)
         ]
-        select_values += select_values unless having_clause.empty?
 
         select_values.concat group_columns.map { |aliaz, field|
           if field.respond_to?(:as)