Skip to content

Commit

Permalink
change from blank? to empty? on obvious string values to save extra m…
Browse files Browse the repository at this point in the history
…ethod calls
  • Loading branch information
vipulnsward committed Mar 18, 2013
1 parent 4e7292c commit 9ff33fb
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions activerecord/lib/active_record/connection_adapters/column.rb
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ def binary_to_string(value)

def value_to_date(value)
if value.is_a?(String)
return nil if value.blank?
return nil if value.empty?
fast_string_to_date(value) || fallback_string_to_date(value)
elsif value.respond_to?(:to_date)
value.to_date
Expand All @@ -172,14 +172,14 @@ def value_to_date(value)

def string_to_time(string)
return string unless string.is_a?(String)
return nil if string.blank?
return nil if string.empty?

fast_string_to_time(string) || fallback_string_to_time(string)
end

def string_to_dummy_time(string)
return string unless string.is_a?(String)
return nil if string.blank?
return nil if string.empty?

dummy_time_string = "2000-01-01 #{string}"

Expand All @@ -192,7 +192,7 @@ def string_to_dummy_time(string)

# convert something to a boolean
def value_to_boolean(value)
if value.is_a?(String) && value.blank?
if value.is_a?(String) && value.empty?
nil
else
TRUE_VALUES.include?(value)
Expand Down

0 comments on commit 9ff33fb

Please sign in to comment.