Merge pull request #31652 from kami-zh/activestorage-callbacks

Change Active Storage destroy callbacks
rails · Jan 9, 2018 · baa88b8 · baa88b8
2 parents 428939b + 9431529
commit baa88b8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/activestorage/CHANGELOG.md b/activestorage/CHANGELOG.md
@@ -1,3 +1,9 @@
+*   Use `after_destroy_commit` instead of `before_destroy` for purging
+    attachments when a record is destroyed.
+
+    *Hiroki Zenigami*
+
+
 *   Force `:attachment` disposition for specific, configurable content types.
     This mitigates possible security issues such as XSS or phishing when
     serving them inline. A list of such content types is included by default,

diff --git a/activestorage/lib/active_storage/attached/macros.rb b/activestorage/lib/active_storage/attached/macros.rb
@@ -44,7 +44,7 @@ def #{name}=(attachable)
       scope :"with_attached_#{name}", -> { includes("#{name}_attachment": :blob) }
 
       if dependent == :purge_later
-        before_destroy { public_send(name).purge_later }
+        after_destroy_commit { public_send(name).purge_later }
       end
     end
 
@@ -89,7 +89,7 @@ def #{name}=(attachables)
       scope :"with_attached_#{name}", -> { includes("#{name}_attachments": :blob) }
 
       if dependent == :purge_later
-        before_destroy { public_send(name).purge_later }
+        after_destroy_commit { public_send(name).purge_later }
       end
     end
   end