Skip to content

Commit

Permalink
Fix tests.
Browse files Browse the repository at this point in the history
Since b6ab441 the single quotes are
being escaped in the templates.
  • Loading branch information
rafaelfranca committed Aug 2, 2012
1 parent 4028bed commit d875247
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions railties/test/application/assets_test.rb
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ def show_detailed_exceptions?() true end


get '/posts' get '/posts'
assert_match(/AssetNotPrecompiledError/, last_response.body) assert_match(/AssetNotPrecompiledError/, last_response.body)
assert_match(/app.js isn't precompiled/, last_response.body) assert_match(/app.js isn't precompiled/, last_response.body)
end end


test "assets raise AssetNotPrecompiledError when manifest file is present and requested file isn't precompiled if digest is disabled" do test "assets raise AssetNotPrecompiledError when manifest file is present and requested file isn't precompiled if digest is disabled" do
Expand All @@ -257,7 +257,7 @@ class ::PostsController < ActionController::Base ; end


get '/posts' get '/posts'
assert_match(/AssetNotPrecompiledError/, last_response.body) assert_match(/AssetNotPrecompiledError/, last_response.body)
assert_match(/app.js isn't precompiled/, last_response.body) assert_match(/app.js isn&#x27;t precompiled/, last_response.body)
end end


test "precompile properly refers files referenced with asset_path and and run in the provided RAILS_ENV" do test "precompile properly refers files referenced with asset_path and and run in the provided RAILS_ENV" do
Expand Down

2 comments on commit d875247

@carlosantoniodasilva
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to ask @spastorino about it, but forgot. Thanks.

@spastorino
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct I'm having second thoughts about the ERB::Util.html_escape thing I did. It's probably better to just follow bambi's (@rafaelfranca ) approach

Please sign in to comment.