Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Select tags with array options are deprecated, removing

  • Loading branch information...
commit db57e92784f83d62a067282a131d7b09b44c3032 1 parent eb8a24a
@carlosantoniodasilva carlosantoniodasilva authored josevalim committed
View
4 actionpack/lib/action_view/helpers/form_tag_helper.rb
@@ -93,10 +93,6 @@ def form_tag(url_for_options = {}, options = {}, *parameters_for_url, &block)
# # => <select disabled="disabled" id="destination" name="destination"><option>NYC</option>
# # <option>Paris</option><option>Rome</option></select>
def select_tag(name, option_tags = nil, options = {})
- if Array === option_tags
- ActiveSupport::Deprecation.warn 'Passing an array of option_tags to select_tag implicitly joins them without marking them as HTML-safe. Pass option_tags.join.html_safe instead.', caller
- end
-
html_name = (options[:multiple] == true && !name.to_s.ends_with?("[]")) ? "#{name}[]" : name
if blank = options.delete(:include_blank)
if blank.kind_of?(String)
View
6 actionpack/test/template/form_tag_helper_test.rb
@@ -201,12 +201,6 @@ def test_select_tag_with_include_blank_with_string
assert_dom_equal expected, actual
end
- def test_select_tag_with_array_options
- assert_deprecated /array/ do
- select_tag "people", ["<option>david</option>"]
- end
- end
-
def test_text_area_tag_size_string
actual = text_area_tag "body", "hello world", "size" => "20x40"
expected = %(<textarea cols="20" id="body" name="body" rows="40">hello world</textarea>)
Please sign in to comment.
Something went wrong with that request. Please try again.