Skip to content

Commit

Permalink
Add jruby-openssl gem in Gemfile necessary for JRuby
Browse files Browse the repository at this point in the history 
[#5762 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
  • Loading branch information
@anildigital @spastorino
anildigital authored and spastorino committed Oct 7, 2010
1 parent 1e63a05 commit ea30da3
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions Gemfile
View file
Expand Up @@ -55,6 +55,8 @@ platforms :jruby do

gem "activerecord-jdbcsqlite3-adapter"

gem "jruby-openssl"

This comment has been minimized.

Sign in to view

Copy link
@fxn

fxn Oct 7, 2010

Member

Albeit the rest of dependencies are clear, this one is not in my view. I think it would be good to add a comment

# Needed because Active Resource does such and such stuff.

or whatever.

This comment has been minimized.

Sign in to view

Copy link
@spastorino

spastorino Oct 7, 2010

Contributor

Xavier, this is temporary, I've talked with Nick Sieger and we agreed to add it until JRuby merge jruby-openssl package in jruby package.
But now the problem is that you can't bundle install using JRuby if Gemfile doesn't have this line.
I will push a comment saying that ;).

This comment has been minimized.

Sign in to view

Copy link
@fxn

fxn Oct 7, 2010

Member

There's some misunderstanding somewhere. Anil said in the ticket he could bundle install without the library, is that correct Anil?

This comment has been minimized.

Sign in to view

Copy link
@spastorino

spastorino Oct 7, 2010

Contributor

Xavier yeah he said that he couldn't run some tests without this. Anyways JRuby needs this package to work with Rails so until they merge the jruby-openssl this could be in

This comment has been minimized.

Sign in to view

Copy link
@fxn

fxn Oct 7, 2010

Member

Absolutely, but if bundle install works the comment cannot say this is needed for bundle install to work. See what I mean?

This comment has been minimized.

Sign in to view

Copy link
@spastorino

spastorino Oct 7, 2010

Contributor

Yeah i've pushed saying that tests doesn't work http://github.com/rails/rails/commit/ad13eb72959f685927b5212ed387d51142d51805

This comment has been minimized.

Sign in to view

Copy link
@fxn

fxn Oct 7, 2010

Member

cool :)

group :db do
gem "activerecord-jdbcmysql-adapter"
gem "activerecord-jdbcpostgresql-adapter"
Expand Down

0 comments on commit ea30da3

Please sign in to comment.