-
Notifications
You must be signed in to change notification settings - Fork 21.6k
Commit
Closes #15024. These operations happen before instances are created. The current behavior is misleading and can result in broken behavior.
- Loading branch information
There are no files selected for viewing
5 comments
on commit ed56e59
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @matthewd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@senny when removing this deprecation should we raise an exception when arity is greater than 0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rafaelfranca committed 4ed9797
Possibly a typo?
... fully possibly.
->... fully possible.