Permalink
Browse files

Remove support for the protected attributes gem

Related to #10690.
  • Loading branch information...
carlosantoniodasilva committed Jan 9, 2015
1 parent d8b8a72 commit f4fbc0301021f13ae05c8e941c8efc4ae351fdf9
Showing with 6 additions and 10 deletions.
  1. +4 −0 activerecord/CHANGELOG.md
  2. +2 −10 activerecord/lib/active_record/core.rb
@@ -1,3 +1,7 @@
+* Remove support for the `protected_attributes` gem.
+
+ *Carlos Antonio da Silva + Roberto Miranda*
+
* Fix accessing of fixtures having non-string labels like Fixnum.
*Prathamesh Sonpatki*
@@ -274,16 +274,14 @@ def table_metadata # :nodoc:
# ==== Example:
# # Instantiates a single new object
# User.new(first_name: 'Jamie')
- def initialize(attributes = nil, options = {})
+ def initialize(attributes = nil)
@attributes = self.class._default_attributes.dup
self.class.define_attribute_methods
init_internals
initialize_internals_callback
- # +options+ argument is only needed to make protected_attributes gem easier to hook.
- # Remove it when we drop support to this gem.
- init_attributes(attributes, options) if attributes
+ assign_attributes(attributes) if attributes
yield self if block_given?
_run_initialize_callbacks
@@ -557,12 +555,6 @@ def init_internals
def initialize_internals_callback
end
- # This method is needed to make protected_attributes gem easier to hook.
- # Remove it when we drop support to this gem.
- def init_attributes(attributes, options)
- assign_attributes(attributes)
- end
-
def thaw
if frozen?
@attributes = @attributes.dup

3 comments on commit f4fbc03

@senny

This comment has been minimized.

Show comment
Hide comment
@senny

senny Dec 23, 2015

Member

@carlosantoniodasilva found this while working on the release notes for 5.0. Does mean that protected_attributes is not intended to work with Rails 5?

/cc @rafaelfranca

Member

senny replied Dec 23, 2015

@carlosantoniodasilva found this while working on the release notes for 5.0. Does mean that protected_attributes is not intended to work with Rails 5?

/cc @rafaelfranca

@carlosantoniodasilva

This comment has been minimized.

Show comment
Hide comment
@carlosantoniodasilva

carlosantoniodasilva Dec 23, 2015

Member

Right, it's Rails 4x only 👍

Right, it's Rails 4x only 👍

Please sign in to comment.