Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra case. #11827

Merged
merged 1 commit into from
Aug 26, 2013
Merged

Remove extra case. #11827

merged 1 commit into from
Aug 26, 2013

Conversation

vipulnsward
Copy link
Member

Remove extra case.

@GeekOnCoffee
Copy link

@vipulnsward Can you provide some background on why this is being removed?

This will cause a binary column to get passed to "'#{quote_string(value)}'" which will have a different outcome.

spastorino added a commit that referenced this pull request Aug 26, 2013
@spastorino
Merge pull request #11827 from vipulnsward/remove_extra_case
6c1bf46 
Remove extra case.
@spastorino spastorino merged commit 6c1bf46 into rails:master Aug 26, 2013
@spastorino
Copy link
Contributor

@GeekOnCoffee you were looking at the wrong case statement. Basically the else case does the same as binary case was doing. Look

rails/activerecord/lib/active_record/connection_adapters/abstract/quoting.rb

Line 57 in 6c1bf46

value

@vipulnsward vipulnsward deleted the remove_extra_case branch February 22, 2016 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vipulnsward @GeekOnCoffee @spastorino