New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing tests for subclassed arrays #141
Closed
lardawge
wants to merge
925
commits into
rails:master
from
lardawge:add_missing_tests_for_subclassed_arrays
Closed
Add missing tests for subclassed arrays #141
lardawge
wants to merge
925
commits into
rails:master
from
lardawge:add_missing_tests_for_subclassed_arrays
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because everybody is not using ActiveRecord. And the logger is not specific to it.
…ot escaping but sanitizing.
…ic option of ActiveRecord
…n removed from Rails
Signed-off-by: José Valim <jose.valim@gmail.com>
Signed-off-by: José Valim <jose.valim@gmail.com>
[rails#5978 state:committed]
…status codes being located in action_controller/status_codes.rb
…ig.filter_parameters
… in config/boot.rb
…e so short inflections like ors do not affect larger words like sponsors [rails#6093 state:resolved]
…o be duplicated or grow forever if you call register_*_expansion more than once Fix a Regression introduced here 55b13c5
matthewd
pushed a commit
that referenced
this pull request
Apr 24, 2018
feature: add Arel::SelectManager#projections method
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a backport of tests from edge for regression purposes.