Fix several warnings: change version of nokogiri gem #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spastorino
added a commit
that referenced
this pull request
Jun 16, 2011
Fix several warnings: change version of nokogiri gem
jake3030
pushed a commit
to jake3030/rails
that referenced
this pull request
Jun 28, 2011
This avoids repeatedly calling SHOW COLUMNS when the association is queried [rails#1738 state:committed]
jake3030
pushed a commit
to jake3030/rails
that referenced
this pull request
Jun 28, 2011
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you run 'rake test' there are several warnings about mismatched indentations at 'end' and 'def' or 'module' etc:
So the problem was in nokogiri gem 1.4.4 version, i found it was fixed (https://github.com/tenderlove/nokogiri/commit/f1e3133b0c689e619964217e2a5b3e055bbb2cc7) and bumped version to 1.4.5 stable. I suggest change version in Gemfile to 1.4.5, it solves this problem.