Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xml_http_request fails in IntegrationTests with 3-1-stable #2107

Closed
rubys opened this issue Jul 16, 2011 · 4 comments
Closed

xml_http_request fails in IntegrationTests with 3-1-stable #2107

rubys opened this issue Jul 16, 2011 · 4 comments
Assignees
Milestone

Comments

@rubys
Copy link
Contributor

rubys commented Jul 16, 2011

Recent regression in 3-1-stable with Ruby 1.8.7 (works in 3.0.9 with either 1.8.7 or 1.9.2; and works in 3-1-stable with 1.9.2).

Steps to reproduce:

  1. Create test/integration/user_stories_test.rb with the following content:
require 'test_helper'
class ProductIntegrationTest < ActionDispatch::IntegrationTest
  test 'xhr' do
    xml_http_request :post, '/products', :id => 1
  end
end
  1. Execute the following command:
rake --trace test:integration

expected output (1.9.2)
actual output (1.8.7)

@spastorino
Copy link
Contributor

This is a rack regression I've fixed it here rack/rack#210

@rubys
Copy link
Contributor Author

rubys commented Jul 18, 2011

I don't believe that this rails issue should be closed until there is a release of rack that fixes the problem.

The current state is: rails 3.0 w/ rack 1.3.1 works; rails 3-1-stable w/ rack 1.3.1 does not.

@spastorino
Copy link
Contributor

@rubys yeah I'm talking with the rack guys about this, anyways doesn't hurt to keep it open just in case :)

@spastorino spastorino reopened this Jul 18, 2011
@spastorino
Copy link
Contributor

As a reminder this is related #2070 bfolkens@d895104

@ghost ghost assigned tenderlove and spastorino Jul 18, 2011
arunagw pushed a commit to arunagw/rails that referenced this issue Jul 26, 2011
arunagw pushed a commit to arunagw/rails that referenced this issue Aug 14, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants