Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Shoryuken adapter? #23311
What's the process to add a new Active Job adapter to Rails? I would like know what are the criteria before attempting to create a pull request for a Shoryuken Queue Adapter.
Shoryuken is very similar to Sidekiq, but for AWS SQS. For SQS, you can also use aws-sdk-ruby directly, but Shoryuken offers workers, multi-threading, long running process etc that are not available on the official SDK. Based on a search for SQS on RubyGems, I believe Shoryuken is the most popular message processor for SQS.
This issue is inspired by the comment below from @avokhmin.
I have two posts related to Shoryuken, Sidekiq and SQS that might motivate the acceptance of this request:
hm thanks @optimisticanshul
I'm kind of against of it as well ^ and I also agree with:
For me it's easier to update an adapter on shoryuken repo than in Rails. I believe that the responsibility of maintaining the adapter should belong to library not to Rails.
So why not removing all these adapters to avoid confusion, also reducing dependencies on Rails?
@maclover7 it's already in there:
I believe the current question is more like asking for the Rails way of doing that. Because currently it seems to be mixed. Some libraries have the adapters inside themselves and others on Rails.
Maybe we can assume that the ones that are on Rails is for backwards compatibility and they will be deprecated in future releases. Because I do agree, that those adapters shouldn't be on Rails itself, unless it's the Rails way.