New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shoryuken adapter? #23311

Closed
phstc opened this Issue Jan 28, 2016 · 6 comments

Comments

Projects
None yet
4 participants
@phstc
Contributor

phstc commented Jan 28, 2016

Hi

What's the process to add a new Active Job adapter to Rails? I would like know what are the criteria before attempting to create a pull request for a Shoryuken Queue Adapter.

Shoryuken is very similar to Sidekiq, but for AWS SQS. For SQS, you can also use aws-sdk-ruby directly, but Shoryuken offers workers, multi-threading, long running process etc that are not available on the official SDK. Based on a search for SQS on RubyGems, I believe Shoryuken is the most popular message processor for SQS.

This issue is inspired by the comment below from @avokhmin.

PS: maybe try to add the shoryuken adapter to the rails?
phstc/shoryuken#174 (comment)

I have two posts related to Shoryuken, Sidekiq and SQS that might motivate the acceptance of this request:

@sharmaanshul2102

This comment has been minimized.

Contributor

sharmaanshul2102 commented Jan 28, 2016

@maclover7

This comment has been minimized.

Member

maclover7 commented Jan 28, 2016

@rafaelfranca Do we want to add more adapters? I am personally against this, I believe you are as well.

@maclover7 maclover7 added the activejob label Jan 28, 2016

@phstc

This comment has been minimized.

Contributor

phstc commented Jan 28, 2016

@phstc #21406

hm thanks @optimisticanshul

@rafaelfranca Do we want to ad more adapters? I am personally against this, I believe you are as well.

I'm kind of against of it as well ^ and I also agree with:

I really believe we should stop including new adapters and encourage library author to maintain their adapters.
#21406 (comment)

For me it's easier to update an adapter on shoryuken repo than in Rails. I believe that the responsibility of maintaining the adapter should belong to library not to Rails.

So why not removing all these adapters to avoid confusion, also reducing dependencies on Rails?

@maclover7

This comment has been minimized.

Member

maclover7 commented Jan 28, 2016

I'd say for now to go ahead and add an ActiveJob adapter to shoryuken directly, but adding to ActiveJob itself is up in the air.

@phstc

This comment has been minimized.

Contributor

phstc commented Jan 28, 2016

I'd say for now to go ahead and add an ActiveJob adapter to shoryuken directly

@maclover7 it's already in there:

I believe the current question is more like asking for the Rails way of doing that. Because currently it seems to be mixed. Some libraries have the adapters inside themselves and others on Rails.

Maybe we can assume that the ones that are on Rails is for backwards compatibility and they will be deprecated in future releases. Because I do agree, that those adapters shouldn't be on Rails itself, unless it's the Rails way.

@rafaelfranca

This comment has been minimized.

Member

rafaelfranca commented Jan 28, 2016

We are not accepting new adapters. What are already here we don't need to remove but we also don't need to add more. Also, please use the Rails core mailing list to ask questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment