Skip to content

Add documentation about not accepting PRs for new adapters #32298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Add documentation about not accepting PRs for new adapters #32298

merged 1 commit into from
Mar 19, 2018

Conversation

jagthedrummer
Copy link
Contributor

Summary

This just adds some documentation that the Rails team is not accepting PRs for new ActiveJob adapters. This will prevent future potential contributors from spending time on PRs that will never have a chance of being accepted.

Other Information

Inspired by:

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@rafaelfranca
Copy link
Member

We may in future add an adapter for Faktory by default given it get the same traction as Sidekiq, but for now I agree it is better to keep it in the Faktory gem itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants