-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add progressive JPG MIME-type to default variable content types #34455
Add progressive JPG MIME-type to default variable content types #34455
Conversation
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if we already include variants of jpeg by default (image/jpg
), and browsers support progressive jpegs, we should too. Can you please add a changelog entry?
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks! Please squash your commits and we can look at getting this merged.
2f83558
to
455a122
Compare
I think the non-standard MIME type Could you see “Uploaded MIME Types” in the following official page? The old Internet Explorer provides So, the following sentence in the CHANGELOG is not so suitable, I think.
|
Summary
I want to suggest including the MIME-type for progressive JPGs (
image/pjpeg
) in the list of variable content types. It is not an uncommon MIME-type and including it in the default list might save a bunch of people some debugging time, when something like this does not work out of the box:I know, you can configure this on a per-app basis, but I think it would also be reasonable to have this in the default list.