Fix safe_constantize to not raise a LoadError. #34892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djberg96
reviewed
Jan 7, 2019
| @@ -328,6 +328,8 @@ def safe_constantize(camel_cased_word) | |||
| e.name.to_s == camel_cased_word.to_s) | |||
| rescue ArgumentError => e | |||
| raise unless /not missing constant #{const_regexp(camel_cased_word)}!$/.match?(e.message) | |||
| rescue LoadError => e | |||
| rause unless /Unable to autoload constant/.match?(e.message) | |||
There was a problem hiding this comment.
We might also want to add #{const_regexp(camel_cased_word)} to the end of this regex to ensure we're catching the right load error. Might be a good idea to test this actually raises now too seeing how CI is passing with a typo 🤔
gmcgibbon
reviewed
Jan 7, 2019
kbrock
force-pushed
the
safer_safe_constantize
branch
from
8bd1dad
to
a0c1cfb
Compare
|
Thank you @gmcgibbon and @djberg96
|
|
👍 |
kbrock
force-pushed
the
safer_safe_constantize
branch
from
a0c1cfb
to
cfaa416
Compare
### Summary There was an issues when using `safe_constantize` on a string that has the wrong case. File `em.rb` defines `EM`. `"Em".safe_constantize` causes a little confusion with the autoloader. The autoloader finds file "em.rb", expecting it to define `Em`, but `Em` is not defined. The autoloader raises a `LoadError`, which is good, But `safe_constantize` is defined to return `nil` when a class is not found. ### Before ``` "Em".safe_constantize LoadError: Unable to autoload constant Em, \ expected rails/activesupport/test/autoloading_fixtures/em.rb to define it ``` ### After ``` "Em".safe_constantize # => nil ```
kbrock
force-pushed
the
safer_safe_constantize
branch
from
cfaa416
to
a930f5b
Compare
|
fixed Changelog conflict... @gmcgibbon thank you so much for your help (and your patience for having to repeat that) |
|
odd collate error for mysql (that I haven't seen before) |
gmcgibbon
approved these changes
Jan 10, 2019
rafaelfranca
added a commit
that referenced
this pull request
Jan 10, 2019
Fix safe_constantize to not raise a LoadError.
|
Thanks for all the help on this PR, and rails in general. It is hard work maintaining OSS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was an issues when using
safe_constantizeon a string that has the wrong case.File
em.rbdefinesEM."Em".safe_constantizecauses a little confusion with the autoloader.The autoloader finds file "em.rb", expecting it to define
Em, butEmis not defined.The autoloader raises a
LoadError, which is good, butsafe_constantizeis defined to returnnilwhen a class is not found.Before
After