Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected argument passed to generator #34979

Closed
jcoyne opened this issue Jan 19, 2019 · 1 comment
Closed

Unexpected argument passed to generator #34979

jcoyne opened this issue Jan 19, 2019 · 1 comment
Labels
attached PR railties

Comments

@jcoyne
Copy link
Contributor

jcoyne commented Jan 19, 2019

Steps to reproduce

I believe this change: f173ec7#diff-5036eb99239f9418c0458f2a2ec4f496R228
introduced a regression whereby RAILS_ENV=test is added as an argument to the generator. This is only apparent if the generator uses arguments. One generator that does so is the devise generator. See heartcombo/devise#5007

Expected behavior

It should not pass RAILS_ENV as an argument to the generator

Actual behavior

it is passing RAILS_ENV as an agrument

System configuration

Rails version: 6.0.0.beta1

Ruby version: 2.6.0
@jcoyne jcoyne mentioned this issue Jan 19, 2019
Closed
@y-yagi
Copy link
Member

y-yagi commented Jan 19, 2019

Thanks for your report. I will fix.

y-yagi added a commit to y-yagi/rails that referenced this issue Jan 19, 2019
@y-yagi
Don't add RAILS_ENV in generate action
82e9866 
In the case of generator, `RAILS_ENV` is interpreted as an argument as it
is. Avoid this because it will result unintended by the user.

Fixes rails#34979.
@y-yagi y-yagi mentioned this issue Jan 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
attached PR railties
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jcoyne @y-yagi @gmcgibbon