adding more finder deprecation info in upgrade documentation [ci skip] #12030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -175,7 +175,9 @@ this gem such as `whitelist_attributes` or `mass_assignment_sanitizer` options. | |||
| * Rails 4.0 has deprecated the old-style hash based finder API. This means that | |||
| methods which previously accepted "finder options" no longer do. | |||
|
|
|||
| * All dynamic methods except for `find_by_...` and `find_by_...!` are deprecated. | |||
| * The `find(...)` method can be replaced with `where(id: ...).first!`. If `id` is not the primary key, use the appropriate primary key. `where(id: ...).first!` will return an unspecific error message, "ActiveRecord::RecordNotFound", so if you need a message like the original finder, you'll need to use `first`, and if nil then raise manually, e.g. `raise ActiveRecord::RecordNotFound.new("Couldn't find (the model class name) with id=...")`. If you would rather return nil than raise an error when the requested record is missing, use `where(id: ...).first`. | |||
There was a problem hiding this comment.
find is not deprecated, why should the users replace it with the more verbose version?
There was a problem hiding this comment.
Oops, sorry about that.
|
Thanks @senny. New changes look ok? |
senny
added a commit
that referenced
this pull request
Aug 27, 2013
adding more finder deprecation info in upgrade documentation [ci skip]
|
@garysweaver thank you for your contribution 💛 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making changes mentioned in #12015 (comment) to add to finders info in Rails upgrade guide.