Propagate association extensions to scopes called on the association. #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase your patch please? it doesn't apply cleanly on master anymore. |
matthewd
pushed a commit
that referenced
this pull request
Apr 24, 2018
Revert fixes involving issue #99 (which makes Arel unusable in large datasets)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension modules defined on associations are added to the association proxy itself, but are not propagated to scopes created from that association proxy. This commit fixes that.
(The two assertions in the test case cover both built-in scope methods such as
where,limit, etc., as well as scopes defined on the target class of the association. During initial development, I tried a solution that addressed built-in scopes but failed for named scopes on the target class.)