Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
button_tag
helper isn't very helpful at the moment for two reasons:type
attribute to"button"
, which is unexpected sincetype="submit"
is HTML's default for the<button>
element; and<button>
(instead of<input type="submit">
et al) is that you want to include styled text or other elements like images.These two commits fix the implementation, tests and docs for these two issues respectively.