-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add locale selector to email preview #19923
Conversation
@@ -2,6 +2,8 @@ class Rails::ApplicationController < ActionController::Base # :nodoc: | |||
self.view_paths = File.expand_path('../templates', __FILE__) | |||
layout 'application' | |||
|
|||
before_action :set_locale |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this going to generic ApplicationController? It's an unrelated change to emails, although perhaps useful to discuss in it's own right.
@egilburg Rails::MailersController inherited from Rails::ApplicationController and use locale. I hope Rails::WelcomeController and Rails::InfoController can also be translated. |
This will not happen. I can see reasons to accept different locales in mail previews since it change the result of the email body but not in Welcome and Info controllers. Let move this behavior to |
[ci skip] Don’t encourage `sudo gem install`
Conflicts: railties/lib/rails/templates/rails/mailers/email.html.erb
Please squash the commits. Thanks! |
Closing in favor of #31596. |
@rafaelfranca Fix of #19922