Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add locale selector to email preview #19923

Closed
wants to merge 7 commits into from

Conversation

Projects
None yet
5 participants
@plus3x
Copy link

plus3x commented Apr 28, 2015

@@ -2,6 +2,8 @@ class Rails::ApplicationController < ActionController::Base # :nodoc:
self.view_paths = File.expand_path('../templates', __FILE__)
layout 'application'

before_action :set_locale

This comment has been minimized.

Copy link
@egilburg

egilburg Apr 28, 2015

Contributor

Is this going to generic ApplicationController? It's an unrelated change to emails, although perhaps useful to discuss in it's own right.

@plus3x

This comment has been minimized.

Copy link
Author

plus3x commented Apr 28, 2015

@egilburg Rails::MailersController inherited from Rails::ApplicationController and use locale. I hope Rails::WelcomeController and Rails::InfoController can also be translated.

@rafaelfranca

This comment has been minimized.

Copy link
Member

rafaelfranca commented May 4, 2015

I hope Rails::WelcomeController and Rails::InfoController can also be translated.

This will not happen. I can see reasons to accept different locales in mail previews since it change the result of the email body but not in Welcome and Info controllers.

Let move this behavior to Rails::MailersController

rafaelfranca and others added some commits May 12, 2015

@repinel

This comment has been minimized.

Copy link
Member

repinel commented Jun 16, 2015

Please squash the commits. Thanks!

@kamipo

This comment has been minimized.

Copy link
Member

kamipo commented Jan 11, 2018

Closing in favor of #31596.

@kamipo kamipo closed this Jan 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.