Add stored procedure test in mysql2 #21932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @sgrif (@rails-bot has picked a reviewer for you, use r? to override) |
| # | ||
| # In MySQL 5.6, CLIENT_MULTI_RESULTS is enabled by default. | ||
| # http://dev.mysql.com/doc/refman/5.6/en/call.html | ||
| if current_adapter?(:MysqlAdapter) && |
There was a problem hiding this comment.
You don't need to check the current adapter here.
|
Can you add a test for a procedure that returns more than one row? |
kamipo
force-pushed
the
add_stored_procedure_test_in_mysql2
branch
from
928f737
to
0ce9cfa
Compare
|
Thank you for your review. I added a test for a procedure that returns more than one row! |
| DROP PROCEDURE IF EXISTS topics; | ||
| SQL | ||
|
|
||
| ActiveRecord::Base.connection.execute <<-SQL |
There was a problem hiding this comment.
Could these be merged into a single command?
There was a problem hiding this comment.
We need to enable CLIENT_MULTI_STATEMENTS for multiple statements into a single command.
https://dev.mysql.com/doc/refman/5.6/en/c-api-multiple-queries.html
Should we enable the option for these queries?
|
A few more nitpicks. You can squash after they're addressed. |
kamipo
force-pushed
the
add_stored_procedure_test_in_mysql2
branch
from
0ce9cfa
to
049cd1a
Compare
kamipo
force-pushed
the
add_stored_procedure_test_in_mysql2
branch
from
049cd1a
to
d39b6f7
Compare
sgrif
added a commit
that referenced
this pull request
Oct 20, 2015
…sql2 Add stored procedure test in mysql2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.