Skip to content

Remove legacy mysql adapter - #22642

Merged
matthewd merged 1 commit into
rails:masterfrom
seuros:remove-mysql-adapter
Dec 18, 2015
Merged

Remove legacy mysql adapter#22642
matthewd merged 1 commit into
rails:masterfrom
seuros:remove-mysql-adapter

Conversation

@seuros

@seuros seuros commented Dec 17, 2015

Copy link
Copy Markdown
Member

Fixes #16891

@seuros seuros added this to the 5.0.0 milestone Dec 17, 2015
@fillman

fillman commented Dec 17, 2015

Copy link
Copy Markdown
Contributor

tumblr_inline_nr7ry9rea21sh9sko_400

@fillman

fillman commented Dec 17, 2015

Copy link
Copy Markdown
Contributor

Cudos to all the contributors of this gem.

@maclover7

maclover7 commented Dec 17, 2015

Copy link
Copy Markdown
Contributor

Is this a dup of #16891?

@guilleiguaran

guilleiguaran commented Dec 17, 2015

Copy link
Copy Markdown
Member

is this going to be extracted to a separated gem?

@matthewd

matthewd commented Dec 18, 2015

Copy link
Copy Markdown
Member

@guilleiguaran yes... I believe the plan is that we'll extract it in a working form, then hand it over to someone who actually uses mysql.

@matthewd
matthewd merged commit fb24d0e into rails:master Dec 18, 2015
matthewd added a commit that referenced this pull request Dec 18, 2015
@matthewd
Merge pull request #22642 from seuros/remove-mysql-adapter
4a58aef 
Remove legacy mysql adapter
@seuros
seuros deleted the remove-mysql-adapter branch December 19, 2015 08:13
kamipo added a commit to kamipo/rails that referenced this pull request Dec 19, 2015
@kamipo
Remove unused test/schema/mysql_specific_schema.rb
d9ca8e2 
Follow up to rails#22642.
@kamipo kamipo mentioned this pull request Dec 19, 2015
Merged
@rajcybage rajcybage mentioned this pull request Dec 20, 2015
Merged
kamipo added a commit to kamipo/rails that referenced this pull request Dec 20, 2015
@kamipo
Remove legacy mysql adapter
af9878d 
Follow up to rails#22642.
@kamipo kamipo mentioned this pull request Dec 20, 2015
Merged
@rafaelfranca rafaelfranca modified the milestones: 5.0.0 [temp], 5.0.0 Dec 30, 2015
@vipulnsward vipulnsward mentioned this pull request May 7, 2016
Closed
@koic koic mentioned this pull request Aug 12, 2016
Closed
kamipo added a commit that referenced this pull request Sep 2, 2020
@kamipo
Revert "Merge pull request #19881 from sikachu/silence-mysql-errno-wa…
f08ae57 
…rning"

This reverts commit 55d9e49, reversing
changes made to 03e987c.

Legacy mysql adapter is already removed in #22642.
kamipo added a commit that referenced this pull request Sep 14, 2020
@kamipo
Revert "Merge pull request #19881 from sikachu/silence-mysql-errno-wa…
d097ee9 
…rning"

This reverts commit 55d9e49, reversing
changes made to 03e987c.

Legacy mysql adapter is already removed in #22642.
eileencodes added a commit to rails/buildkite-config that referenced this pull request Mar 24, 2023
@eileencodes
Remove obsolete mysql task
1babdf9 
The `mysql` gem was removed from Rails in 5.0 (see
rails/rails#22642). We needed to keep the builds
around because at the time we still supported older versions with
`mysql` for security and bug releases.

However, we haven't run a build for 4-2-stable (the last supported
version) since 2020, so let's remove this from the buildkite config.
@eileencodes eileencodes mentioned this pull request Mar 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@rafaelfranca rafaelfranca

Labels

activerecord

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@seuros @fillman @maclover7 @guilleiguaran @matthewd @rafaelfranca