Remove legacy mysql adapter #22642
Merged
Remove legacy mysql adapter #22642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Cudos to all the contributors of this gem. |
|
Is this a dup of #16891? |
|
is this going to be extracted to a separated gem? |
|
@guilleiguaran yes... I believe the plan is that we'll extract it in a working form, then hand it over to someone who actually uses |
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Dec 19, 2015
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Dec 20, 2015
Follow up to rails#22642.
eileencodes
added a commit
to rails/buildkite-config
that referenced
this pull request
Mar 24, 2023
The `mysql` gem was removed from Rails in 5.0 (see rails/rails#22642). We needed to keep the builds around because at the time we still supported older versions with `mysql` for security and bug releases. However, we haven't run a build for 4-2-stable (the last supported version) since 2020, so let's remove this from the buildkite config.
atosbucket
added a commit
to atosbucket/rails-buildkit
that referenced
this pull request
Mar 22, 2024
The `mysql` gem was removed from Rails in 5.0 (see rails/rails#22642). We needed to keep the builds around because at the time we still supported older versions with `mysql` for security and bug releases. However, we haven't run a build for 4-2-stable (the last supported version) since 2020, so let's remove this from the buildkite config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16891