Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy mysql adapter #22642

Merged
merged 1 commit into from
Dec 18, 2015
Merged

Conversation

seuros
Copy link
Member

@seuros seuros commented Dec 17, 2015

Fixes #16891

@seuros seuros added this to the 5.0.0 milestone Dec 17, 2015
@fillman
Copy link
Contributor

fillman commented Dec 17, 2015

tumblr_inline_nr7ry9rea21sh9sko_400

@fillman
Copy link
Contributor

fillman commented Dec 17, 2015

Cudos to all the contributors of this gem.

@maclover7
Copy link
Contributor

Is this a dup of #16891?

@guilleiguaran
Copy link
Member

is this going to be extracted to a separated gem?

@matthewd
Copy link
Member

@guilleiguaran yes... I believe the plan is that we'll extract it in a working form, then hand it over to someone who actually uses mysql.

@matthewd matthewd merged commit fb24d0e into rails:master Dec 18, 2015
matthewd added a commit that referenced this pull request Dec 18, 2015
@seuros seuros deleted the remove-mysql-adapter branch December 19, 2015 08:13
kamipo added a commit to kamipo/rails that referenced this pull request Dec 19, 2015
kamipo added a commit to kamipo/rails that referenced this pull request Dec 20, 2015
@rafaelfranca rafaelfranca modified the milestones: 5.0.0 [temp], 5.0.0 Dec 30, 2015
kamipo added a commit that referenced this pull request Sep 2, 2020
…rning"

This reverts commit 55d9e49, reversing
changes made to 03e987c.

Legacy mysql adapter is already removed in #22642.
kamipo added a commit that referenced this pull request Sep 14, 2020
…rning"

This reverts commit 55d9e49, reversing
changes made to 03e987c.

Legacy mysql adapter is already removed in #22642.
eileencodes added a commit to rails/buildkite-config that referenced this pull request Mar 24, 2023
The `mysql` gem was removed from Rails in 5.0 (see
rails/rails#22642). We needed to keep the builds
around because at the time we still supported older versions with
`mysql` for security and bug releases.

However, we haven't run a build for 4-2-stable (the last supported
version) since 2020, so let's remove this from the buildkite config.
atosbucket added a commit to atosbucket/rails-buildkit that referenced this pull request Mar 22, 2024
The `mysql` gem was removed from Rails in 5.0 (see
rails/rails#22642). We needed to keep the builds
around because at the time we still supported older versions with
`mysql` for security and bug releases.

However, we haven't run a build for 4-2-stable (the last supported
version) since 2020, so let's remove this from the buildkite config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants