Get 5-0-stable happy with Ruby 2.4.0 #27458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use built-in #transform_values when available.
…act-from-ruby-24 Use Hash#compact and Hash#compact! from Ruby 2.4
…rm_values Ensure `#transform_values` of HWIDA to return HWIDA
2.3: sprintf('%0.1f', 5.55) #=> "5.5"
2.4: sprintf('%0.1f', 5.55) #=> "5.6"
see: ruby/ruby@6ed8c79 and
ruby/ruby@295f60b
Remove warning from Bignum constant access
BigDecimal('an invalid string') has changed its behavior to raise an ArgumentError since 1.3.0
https://bugs.ruby-lang.org/issues/10286
fix new warning in ruby 2.4
change return value of `duplicable?` with Ruby 2.4+
Fix Fixnum deprecated warning in Ruby 2.4+
Very similar to PR rails#25758, see more in depth reasoning there.
Revise the "XML is not HTML" test
|
|
3 tasks
siruguri
added a commit
to siruguri/baseline_rails_install
that referenced
this pull request
Jan 26, 2017
* Failed and postponed Ruby 2.4.0: rails/rails#27458
BenMorganIO
added a commit
to receptr/bithub
that referenced
this pull request
Feb 12, 2017
|
Since 5.1.0 beta is released, will there be 5.0.2 with full Ruby 2.4 support? |
huzichunjohn
pushed a commit
to huzichunjohn/gitaly
that referenced
this pull request
Feb 9, 2018
When starting Gitaly as part of the GDK and the user is using Ruby with version 2.4 or later, it would log a few warnings like: ```log time="2018-02-05T11:58:00+01:00" level=info msg="/Users/zegerjan/.rvm/gems/ruby-2.4.2/gems/activesupport-5.0.0.1/lib/active_support/xml_mini.rb:52: warning: constant ::Bignum is deprecated" supervisor.args="[bundle exec bin/ruby-cd /Users/zegerjan/Development/gitlab-development-kit /Users/zegerjan/Development/gitlab-development-kit/gitaly/ruby/bin/gitaly-ruby 18254 /var/folders/xj/tqv1lcpn7fb5b9xmrs55lxz00000gn/T/gitaly-ruby281462536/socket.0]" supervisor.name=gitaly-ruby.0 ``` This deprecation warning has been fixed upstream and the fix was included in 5.0.2: rails/rails#27458
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.