Fix typo in actionview error message in to_form_params helper method #28450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vipulnsward
requested changes
Mar 17, 2017
actionview/CHANGELOG.md
Outdated
| @@ -1,3 +1,6 @@ | |||
| * Fix a typo in error message for to_form_params helper method | |||
| *Adam Gamble* | |||
There was a problem hiding this comment.
This does not need a changelog, please remove this change.
adamgamble
force-pushed
the
bug_fix/fix_typo_in_actionview
branch
from
a54c7f6
to
0a5dacc
Compare
adamgamble
force-pushed
the
bug_fix/fix_typo_in_actionview
branch
from
0a5dacc
to
328ae33
Compare
|
@vipulnsward I have removed the changelog change |
maclover7
approved these changes
Mar 18, 2017
|
@maclover7 @vipulnsward is there anything else you need from me? |
rafaelfranca
added a commit
that referenced
this pull request
Mar 21, 2017
Fix typo in actionview error message in to_form_params helper method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a button without sanitized request params you would previously get this error message:
ArgumentError: Attempting to generate a buttom from non-sanitized request parameters! Whitelist and sanitize passed parameters to be secure.now you get this message:
ArgumentError: Attempting to generate a button from non-sanitized request parameters! Whitelist and sanitize passed parameters to be secure.