[#28431], Adds time zone mapping with country codes for El Salvador #28457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump bundler version in the before_install hook of travis
This reverts commit 4cf4c86. Reason: It broke the build
Listen, when used on JRuby, does have have access to synchronous filesystem events. Instead, it uses a listen loop which has some delay in registering filesystem changes. These tests checked for events to have fired immediately after making filesystem changes, which did not allow time for that listen loop to trigger. I added `wait` to each test, as a few already did, to ensure the events fire. With these changes, the tests are all green on JRuby.
Wait for file events to propagated for slower Listen backends.
JRuby does not support fork, so this test will never pass. Omit it when running on JRuby.
blade has a transitive dependency on curses, which is a C ext and does not install on JRuby.
No blade on jruby
…ruby Mask forking filesystem event on JRuby.
[ci skip] This was pointed out on #15583 (comment) The comment was lost in the changes made by fcd0ac0 and 3e1373a
This is a follow up to #25681, specifically this comment: #25681 (comment) The way the thread local variable is stored is an implementation detail and subject to change. It makes no sense to only generate a reader or writer as you'd have to know where to read from or where it writes to.
`copy_time_to` is a helper function for date and time calculations. It's being used by `prev_week`, `next_week` and `prev_weekday` to keep the time fraction when jumping around between days. Previously the nanoseconds part was lost during the operation. This lead to problems in practice if you were using the `end_of_day` calculation. Resulting in the time fraction of `end_of_day` not being the same as next week's `end_of_day`. With this fix `copy_time_to` doesn't forget the `nsec` digits. (cherry picked from commit fc72d68)
…helper Add examples of queue_adapter and perform_enqueued jobs to API Docs.
This reverts commit 5dde413. Reason: The gem defines it so we don't need to remove
The test framework should not be autoloaded in production mode. Before this commit, the testing railtie would extend AS::TestCase. This caused AS::TestCase to be preloaded regardless of the environment in which we were running. This commit just moves the code that adds line filtering support in to the test command where we actually execute the test runner. That allows us to maintain the line runner feature but only load the minimal amount of code we need.
Skip test that depends on RubyVM when it is not available (JRuby).
Soften this test since YAML.dump may produce keys in other orders.
Lazy-load blade for actioncable tests; no blade on JRuby.
Add missing require in active_support/hash_with_indifferent_access.rb
generate mailer layout files if it does not already exist
Convert ActionController::Parameters to a hash in button_to
We need to use on_load so that plugins will get the same functionality
Revert #26826 and add documentation
The first release note entry mentioned #on_weekday?, but that was only added by the second PR mentioned there. To simplify reading the notes just merge the two, since they are related methods. [ci skip]
Fix model schema doc strings
* Put a blank line after :call-seq: otherwise it will think the whole test is the call seq. * Improve some text. * Use some rdoc formatting. * Restores the documentation of table_name_prefix. [ci skip]
…tests Fix brittle tests which were relying on the error message text from mysql2 gem
This image has copyright that we are not giving so it is better to use one image that we own the copyright.
There were never public API only there by mistake. [ci skip]
This executor currently relies on `ActiveRecord::Base.connection` not
changing between `prepare` and `complete`. If something else returns
the current ActiveRecord connection to the pool early then this
`complete` call will fail to clear the correct query cache and restore
the original `query_cache_enabled` status.
This has for example been happening in Sidekiq:
sidekiq/sidekiq#3166
We can just keep track of the connection as part of the exector state.
…et_to_run_via Prevent multiple values being set to `run_via`
Symptom: /home/rubys/git/rails/railties/lib/rails/commands/test.rb:9:in `<top (required)>': wrong number of arguments (given 2, expected 1) (ArgumentError) from /home/rubys/git/rails/railties/lib/rails/commands/commands_tasks.rb:138:in `require' from /home/rubys/git/rails/railties/lib/rails/commands/commands_tasks.rb:138:in `require_command!' from /home/rubys/git/rails/railties/lib/rails/commands/commands_tasks.rb:95:in `test' from /home/rubys/git/rails/railties/lib/rails/commands/commands_tasks.rb:49:in `run_command!' from /home/rubys/git/rails/railties/lib/rails/commands.rb:18:in `<top (required)>' from bin/rails:4:in `require' from bin/rails:4:in `<main>' See: http://intertwingly.net/projects/AWDwR4/checkdepot-50/section-7.1.html#cmd9
``` Minitest.run_via[:rails] = true ``` 👆 would break because a simple alias won't catch the second true argument there.
Fix regression introduced by 88b335e
(cherry picked from commit 6560448)
Bundler 1.14.5 moved to lazily loading 'rubygems/spec_fetcher' which revealed some missing requires from the JSON encoding test file.
Further missing requires for Timeout exposed due to Bundler 1.14.5
ensure `#compact` of HWIDA to return HWIDA
Fix `wait_timeout` to configurable for mysql2 adapter
…d-rails-engine-take-2 Fix generator command for nested (namespaced) rails engine (take 2)
Add missing module namespacing wrapper
Make HWIA#compact not return nil when no nils
Add missing gzip footer check in ActiveSupport::Gzip.decompress
Allow ActiveSupport::MarshalWithAutoloading#load to take a Proc
…ramework_option Use appropriate type for `test_framework` option
I'm sorry for causing #24168. I wasn't aware of --no-helper and --no-assets. So I'm adding them to the help message. I'm still not sure how to show `--no-test-framework` though.
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @senny (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Under Issue ActiveSupport::TimeZone.country_zones(country_code) fails to find valid Alpha2 #28431 is was found that time_zone.rb had a mapping missing for officially assigned country code(SV) for El Salvador.
It was also verified that Tzinfo returns the appropriate zone_identifier ["America/El_Salvador"]
This pull request adds the Mapping for "America/El_Salvador" zone_identifier.