has_secure_password should allow optional password confirmation #2879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update doc for password_confirmation => false
|
Yep, please merge it! |
|
+1 |
|
So is this merging ? 3.1.1 already out without this :( |
|
+1 |
1 similar comment
|
+1 |
|
Closing this. If password_confirmation = nil, it is not going to be triggered anyway. Just don't set it and it won't bother you. |
|
And @bloomdido, please be nice. Github is about social coding, you are missing the social. |
|
@josevalim I have the following validations set up: validates_presence_of :password, on: :create
validates_confirmation_of :passwordThe behavior I currently see during :update is that if only :password is set and :password_confirmation is nil, confirmation does not kick in. How do I get confirmation to kick in whenever :password is set? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squash of #2837